From owner-svn-src-projects@FreeBSD.ORG  Thu Sep  2 15:00:26 2010
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 49A5610657DF;
	Thu,  2 Sep 2010 15:00:26 +0000 (UTC)
	(envelope-from rysto32@gmail.com)
Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com
	[209.85.215.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 7FB308FC0C;
	Thu,  2 Sep 2010 15:00:25 +0000 (UTC)
Received: by eyx24 with SMTP id 24so354644eyx.13
	for <multiple recipients>; Thu, 02 Sep 2010 08:00:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:in-reply-to
	:references:date:message-id:subject:from:to:cc:content-type;
	bh=pUifwB1qe1NPML1INW0pYQTfl+8y3PzkUz8A5YHSY/s=;
	b=buThCmu6G8HjJnvk/LUzSktlSRannnhiKFeGkAjYY3lCuWeok3pZmniRqYxjDl4+GE
	ENuBSlSJq8tfzlCIjbGEMz8U2iXW4T5RuAqTtFtasfdwp+j1ACLBO4tPA8yPCPetsYDJ
	MJ5RdyEcDSFMqgE/yLJhD6Y1YrNdcZB2l/ZS0=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=EVu9/3yE0Twd45JvvL7cpSbe+kTF5jOza3CGB4JfdBBAkRNIbsUbyYiHM9IacBUFfv
	z/0fblj9NHbME/6QMIbmlR4oBW+vQBDsUwcfDZrjlvplekSe6GqaU+E8Tvw+AxGgayQv
	anR4KShVtQjwVY9mADG5kzebtVc6sD3WuzpRk=
MIME-Version: 1.0
Received: by 10.213.89.205 with SMTP id f13mr1753085ebm.52.1283438113159; Thu,
	02 Sep 2010 07:35:13 -0700 (PDT)
Received: by 10.213.28.19 with HTTP; Thu, 2 Sep 2010 07:35:13 -0700 (PDT)
In-Reply-To: <201009020933.o829XmS9098339@svn.freebsd.org>
References: <201009020933.o829XmS9098339@svn.freebsd.org>
Date: Thu, 2 Sep 2010 10:35:13 -0400
Message-ID: <AANLkTi=+h-Pm+ncXekd4-B6sc5nzKy9Hf8p1pY2RmOCZ@mail.gmail.com>
From: Ryan Stone <rysto32@gmail.com>
To: Attilio Rao <attilio@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r212142 - in projects/sv/sys: amd64/amd64 arm/arm
 geom i386/i386 ia64/ia64 net powerpc/powerpc sparc64/sparc64 sun4v/sun4v sys
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Sep 2010 15:00:26 -0000

On Thu, Sep 2, 2010 at 5:33 AM, Attilio Rao <attilio@freebsd.org> wrote:
> Log:
>  Introduce a flag field for the dumpers and use it immediately for the
>  DIF_NET flag.
>  This flag is responsible for toggling a netdump and having a correct set
>  of dumplo in the dumping routines.
>

To be honest, I'd be happier if the DIF_NET flag disappeared entirely.
 It seems to me that dumpsys shouldn't need knowledge of disk geometry
-- especially now when there may not be a disk at all.  It seems to me
that the correct interface would be for dumpsys to pass the offset
into the core file to the dumper, and the dumper should convert that
to a value appropriate for the dump device.