From owner-freebsd-stable@FreeBSD.ORG  Sat Apr  5 07:57:21 2003
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5B8A537B401; Sat,  5 Apr 2003 07:57:21 -0800 (PST)
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua
	[212.110.138.65])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8933843FAF; Sat,  5 Apr 2003 07:57:16 -0800 (PST)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1])
	h35FvAgg000359
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 5 Apr 2003 18:57:11 +0300 (EEST)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h35Fv7eT000349;
	Sat, 5 Apr 2003 18:57:07 +0300 (EEST)
	(envelope-from ru)
Date: Sat, 5 Apr 2003 18:57:07 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Dag-Erling Sm?rgrav <des@ofug.org>
Message-ID: <20030405155707.GA98409@sunbay.com>
References: <20030404202411.GC82587@sunbay.com>
	<xzp4r5dcg98.fsf@flood.ping.uio.no> <20030405115548.GA76459@sunbay.com>
	<xzpsmsxnewq.fsf@flood.ping.uio.no>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE"
Content-Disposition: inline
In-Reply-To: <xzpsmsxnewq.fsf@flood.ping.uio.no>
User-Agent: Mutt/1.5.4i
cc: stable@FreeBSD.org
cc: Bruce Evans <bde@FreeBSD.org>
Subject: Re: outdated files after make world
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Apr 2003 15:57:21 -0000


--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 05, 2003 at 05:27:01PM +0200, Dag-Erling Sm?rgrav wrote:
> Ruslan Ermilov <ru@freebsd.org> writes:
> > On Sat, Apr 05, 2003 at 01:53:23PM +0200, Dag-Erling Sm?rgrav wrote:
> > > That's still a bug.  If the files match, nothing is copied.  RTFS.
> > Sorry?  Where is the bug?
>=20
> In the documentation.  It should clearly state that the new file is
> not installed if it is identical to the old one.  No monkey business
> about inode times etc., just "not installed".
>=20
Well, not quite.  The code also works around the multiple hard
links problem (in the -s case only) by unlinking the target
but preserving the atime/mtime of the new target.

I'd prefer that we change the definition of "the same" to
also include the fact that the st_nlink be 1, and not
preserve atime/mtime in that case either.  That would
allow us to keep in sync both -C and -Cs cases.

What do you think?


Cheers,
--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

--Kj7319i9nmIyA2yE
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+jvzTUkv4P6juNwoRAhfqAJ45PT3kMqVfUqiHt+T7z9tUS3rOewCdFngA
d+MFq9KXd+t8X3tD/+VZbe0=
=Z/1g
-----END PGP SIGNATURE-----

--Kj7319i9nmIyA2yE--