Date: Mon, 11 Oct 2010 13:15:22 -0700 From: Weongyo Jeong <weongyo.jeong@gmail.com> To: Julian Elischer <julian@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-user@freebsd.org" <svn-src-user@freebsd.org>, Hans Petter Selasky <hselasky@c2i.net> Subject: Re: svn commit: r213540 - user/weongyo/usb/sys/dev/usb/net Message-ID: <20101011201522.GB38869@weongyo> In-Reply-To: <4CB33B04.8070609@freebsd.org> References: <201010080152.o981q1gJ074407@svn.freebsd.org> <201010111739.25082.hselasky@c2i.net> <4CB33B04.8070609@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 11, 2010 at 09:27:48AM -0700, Julian Elischer wrote: > On 10/11/10 8:39 AM, Hans Petter Selasky wrote: > >On Friday 08 October 2010 03:52:01 Weongyo Jeong wrote: > >>Author: weongyo > >>Date: Fri Oct 8 01:52:01 2010 > >>New Revision: 213540 > >>URL: http://svn.freebsd.org/changeset/base/213540 > >> > >>Log: > >> o fixes a regression that setting the promiscuous mode should be > >> happened at the taskqueue. It's to avoid a `sleepable after > >> non-sleepable' because ioctl handler could be called with holding bpf > >> mtx which is a default mutex. > >> o defines SLEEPOUT_DRAIN_TASK helper. > >> > [...] > > >These taskqueues belong in the network stack and not the USB drivers! And > >please understand that you cannot use taskqueues for these commands, > >because > >the events can be executed out of order!!! > > sounds like we should add an option to taskqueues to fix this then. > I'd rather fix the standard facility than make a new one. I agree with you that if it really requires the extension for USB it'd be better to fix the taskqueue than reimplementing almost same thing (usb_process.[ch]). regards, Weongyo Jeong
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101011201522.GB38869>