Date: Sat, 20 Apr 2002 08:43:06 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: current@FreeBSD.ORG, green@FreeBSD.ORG Subject: Re: SSH: LOGIN_CAP limits & ~/.login.conf not processed now Message-ID: <20020420044306.GA1132@nagual.pp.ru> In-Reply-To: <20020420024304.GA95425@nagual.pp.ru> References: <20020420012140.GA66589@nagual.pp.ru> <20020420024304.GA95425@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 20, 2002 at 06:43:05 +0400, Andrey A. Chernov wrote: > On Sat, Apr 20, 2002 at 05:21:42 +0400, Andrey A. Chernov wrote: > > Well, who damages LOGIN_CAP processing in sshd now? It not reads > > ~/.login_conf anymore and not sets LOGIN_CAP limits. > > I see parent environment seriously damaged in do_setusercontext() since > not saved. I mean MAIL,BLOCKSIZE & FTP_PASSIVE_MODE variables, > overwritten by /etc/login.conf Really any environment variable can be > overwritten here, so please restore good old code which saves&restores > parent environment before calling setusercontext(). do_setup_env() code is > broken too because call setusercontext() which modify _current_ > environment, and NOT child one. NOTE: I just commit the fix, see session.c commit log for detailed explanation. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020420044306.GA1132>