Date: Tue, 28 Aug 2012 15:34:08 GMT From: Pietro Cerutti <gahr@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/171142: [patch] lang/otcl -- fix build with Tcl 8.6 + remove limitation on unthreaded version Message-ID: <201208281534.q7SFY8Qc047758@red.freebsd.org> Resent-Message-ID: <201208281540.q7SFe1hd097491@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 171142
>Category: ports
>Synopsis: [patch] lang/otcl -- fix build with Tcl 8.6 + remove limitation on unthreaded version
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Aug 28 15:40:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Pietro Cerutti
>Release:
>Organization:
The FreeBSD Project
>Environment:
>Description:
The patch attached fixes lang/otcl when building against Tcl/Tk 8.6. This new release has made obsolete direct access to the members of Tcl_Interp errorLine and result. Legacy code can define USE_INTERP_ERRORLINE and USE_INTERP_RESULT to directly get to the members.
Moreover, I have removed the limitation on using an unthreaded version of Tk. I have successfully built and run otcl linked against Tcl/Tk 8.6 with threads.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 302796)
+++ Makefile (working copy)
@@ -19,7 +19,6 @@
WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
USE_TK= 82+
-USE_TK_NO_THREADS= yes
USE_XORG= xext
USE_AUTOTOOLS= autoconf
@@ -37,6 +36,10 @@
CFLAGS+= -DHAVE_UNISTD_H
CONFIGURE_ARGS+= --with-tcl-ver=${TCL_VER} --with-tk-ver=${TK_VER}
+.if ${USE_TCL} > 85
+CFLAGS+= -DUSE_INTERP_ERRORLINE -DUSE_INTERP_RESULT
+.endif
+
post-patch:
@${REINPLACE_CMD} -e 's|/usr/X11R6|${LOCALBASE}|g' \
-e's|X11/Intrinsic.h|X11/Xlib.h|g' \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208281534.q7SFY8Qc047758>