From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Aug 28 15:40:01 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ABD5D1065674 for ; Tue, 28 Aug 2012 15:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6438D8FC16 for ; Tue, 28 Aug 2012 15:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7SFe1QZ097492 for ; Tue, 28 Aug 2012 15:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7SFe1hd097491; Tue, 28 Aug 2012 15:40:01 GMT (envelope-from gnats) Resent-Date: Tue, 28 Aug 2012 15:40:01 GMT Resent-Message-Id: <201208281540.q7SFe1hd097491@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pietro Cerutti Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1373D1065676 for ; Tue, 28 Aug 2012 15:34:09 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id F25E08FC1B for ; Tue, 28 Aug 2012 15:34:08 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7SFY8FZ047760 for ; Tue, 28 Aug 2012 15:34:08 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q7SFY8Qc047758; Tue, 28 Aug 2012 15:34:08 GMT (envelope-from nobody) Message-Id: <201208281534.q7SFY8Qc047758@red.freebsd.org> Date: Tue, 28 Aug 2012 15:34:08 GMT From: Pietro Cerutti To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/171142: [patch] lang/otcl -- fix build with Tcl 8.6 + remove limitation on unthreaded version X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2012 15:40:01 -0000 >Number: 171142 >Category: ports >Synopsis: [patch] lang/otcl -- fix build with Tcl 8.6 + remove limitation on unthreaded version >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Aug 28 15:40:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Pietro Cerutti >Release: >Organization: The FreeBSD Project >Environment: >Description: The patch attached fixes lang/otcl when building against Tcl/Tk 8.6. This new release has made obsolete direct access to the members of Tcl_Interp errorLine and result. Legacy code can define USE_INTERP_ERRORLINE and USE_INTERP_RESULT to directly get to the members. Moreover, I have removed the limitation on using an unthreaded version of Tk. I have successfully built and run otcl linked against Tcl/Tk 8.6 with threads. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: Makefile =================================================================== --- Makefile (revision 302796) +++ Makefile (working copy) @@ -19,7 +19,6 @@ WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} USE_TK= 82+ -USE_TK_NO_THREADS= yes USE_XORG= xext USE_AUTOTOOLS= autoconf @@ -37,6 +36,10 @@ CFLAGS+= -DHAVE_UNISTD_H CONFIGURE_ARGS+= --with-tcl-ver=${TCL_VER} --with-tk-ver=${TK_VER} +.if ${USE_TCL} > 85 +CFLAGS+= -DUSE_INTERP_ERRORLINE -DUSE_INTERP_RESULT +.endif + post-patch: @${REINPLACE_CMD} -e 's|/usr/X11R6|${LOCALBASE}|g' \ -e's|X11/Intrinsic.h|X11/Xlib.h|g' \ >Release-Note: >Audit-Trail: >Unformatted: