From owner-svn-src-head@FreeBSD.ORG  Wed Nov  5 07:06:31 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6701F1065670;
	Wed,  5 Nov 2008 07:06:31 +0000 (UTC)
	(envelope-from tim@kientzle.com)
Received: from kientzle.com (kientzle.com [66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 3D2098FC13;
	Wed,  5 Nov 2008 07:06:31 +0000 (UTC)
	(envelope-from tim@kientzle.com)
Received: from [10.123.2.205] (p53.kientzle.com [66.166.149.53])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id mA56futv029743;
	Tue, 4 Nov 2008 22:41:56 -0800 (PST) (envelope-from tim@kientzle.com)
Message-ID: <4911402F.2000305@kientzle.com>
Date: Tue, 04 Nov 2008 22:41:51 -0800
From: Tim Kientzle <tim@kientzle.com>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: d@delphij.net
References: <200811050526.mA55QBk4017410@svn.freebsd.org>
	<491133B1.9050208@delphij.net>
In-Reply-To: <491133B1.9050208@delphij.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	Tim Kientzle <kientzle@FreeBSD.ORG>, src-committers@FreeBSD.ORG
Subject: Re: svn commit: r184668 - head/usr.bin/tar/test
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Nov 2008 07:06:31 -0000

Xin LI wrote:

>>Author: kientzle
>>Date: Wed Nov  5 05:26:11 2008
>>New Revision: 184668
>>URL: http://svn.freebsd.org/changeset/base/184668
>>    
>>
>[...]
>  
>
>>@@ -494,7 +494,8 @@ test_assert_empty_file(const char *f1fmt
>> 	if (fd < 0) {
>> 		fprintf(stderr, "    Unable to open %s\n", f1);
>> 	} else {
>>-		s = sizeof(buff) < st.st_size ? sizeof(buff) : st.st_size;
>>+		s = (sizeof(buff) < (size_t)st.st_size) ?
>>+		    (ssize_t)sizeof(buff) : (ssize_t)st.st_size;
>>    
>>
>
>I'm more or less concerned about this - st_size is off_t, is it safe to
>cast it to size_t when comparing here?
>  
>

Thanks.  I've fixed this.

Tim