From owner-svn-ports-all@freebsd.org Mon May 21 15:57:50 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61531EF5845; Mon, 21 May 2018 15:57:50 +0000 (UTC) (envelope-from marcus@freebsd.org) Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (Client CN "iport.cisco.com", Issuer "HydrantID SSL ICA G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D2E783931; Mon, 21 May 2018 15:57:49 +0000 (UTC) (envelope-from marcus@freebsd.org) X-Files: signature.asc : 195 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BFAgCN6wJb/5NdJa1cGgEBAQEBAgE?= =?us-ascii?q?BAQEIAQEBAYNDYX0VE5hsgVAIIYEPlS4IAx+ETQKCGSE3FQECAQEBAQEBAmw?= =?us-ascii?q?cDIUpAQV5EAsOCi5XBg0GAgEBBYMZAoF/qW2IQYIAD4g1EYICgQ8jDIJdgwa?= =?us-ascii?q?HQQKHYJBsCYNGgVRQiGeBPT6DL4I9hRyKdYYCgSUyIoFSTTAIgn4JiwcuhSw?= =?us-ascii?q?jMJA0AQE?= X-IronPort-AV: E=Sophos;i="5.49,426,1520899200"; d="asc'?scan'208";a="117196112" Received: from rcdn-core-11.cisco.com ([173.37.93.147]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2018 15:57:48 +0000 Received: from [10.118.87.87] (rtp-jclarke-nitro6.cisco.com [10.118.87.87]) by rcdn-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id w4LFvl8B006043; Mon, 21 May 2018 15:57:48 GMT Subject: Re: svn commit: r469754 - in head/ports-mgmt/portlint: . src To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201805121859.w4CIx8jx035047@repo.freebsd.org> <20180515140351.oyfapiqygprxomvq@ogg.in.absolight.net> From: Joe Marcus Clarke Openpgp: preference=signencrypt Autocrypt: addr=marcus@freebsd.org; prefer-encrypt=mutual; keydata= xsDiBDyDmj4RBADa/Icz5Xl+cJUGNxC/tWgXWqcA9VA8GN+PeqKhXS0BnVHntdsQxbpFUUKK 4ld0Zex/Rec1jgC/ikExJHHIee8ZVcHqP+tsWexi83/ZvEdzI95diBp2Is5fYp8P8hdIBNQS Ooc1jVYrTJUaZgJK2uBzbkh/WbipwsQbueRzXqPORwCgsPNrStLzqOpjrA7FdUz/JVQf5+8D /1SiKAOFiW4TxY+fS09lqiLs3mbXjvw23iQwLxje4vBd4+b9iAUWOsSretSKv6OE9ZlD4FYe a8HmMgEkuKfXGc8GvTq4J1uHZ0gcVbrBGmxAUBPPaAENYEJfJf7dcysKVAl14ZQVIvzAGJAZ HGuegD7uekGKnOEA61R3ze4aM2zNA/96I77l0qiMc6J7gXmiD5uxC7FsSCFj5sqTYMgBqzIY EZjU/tTUbth84xcRi4X0WNkaILqq1mOcBfmzQMvzG1n1CydmJU6iF1ewle6cIui9TQYg5CES rJF7xid4vVXRz+xi6hc1+0bSaoJa3sfpNrSSr0lKGdWHZozWdQjOvTMCXc1CSm9lIE1hcmN1 cyBDbGFya2UgKEZyZWVCU0QgY29tbWl0dGVyIGFkZHJlc3MpIDxtYXJjdXNARnJlZUJTRC5v cmc+wl8EExECABcFAjyuLU0FCwcKAwQDFQMCAxYCAQIXgAASCRBvaI+K/hTPhwdlR1BHAAEB 7U0AoICIVoBe9B8bo1lrvHh+UF7GY/WaAJ9C2mCThFrmqxCr2bCtR12UoPCPqs7ATQQ8g5pA EAQAqk1J4LBDLeWs6ZOkPDYYcKCSAu0qlzEf5YP/TcSeZcjJyXILgesFXcayoy1v7ILPQSXj 4p5uzRyn0fuGqiTvajjxMZz1aSkvgGyS+gc+PDmi4SJ2N/tX2isrul8MK+NGeUsLuZaM1JKh gKpq9yuu3D3ELG7ESga7xsOs1V/sSd8AAwUD/20XByIlsUUC/65KG/DQ1WfX2gNuy5If9tSP Q6h1Lno5Hv3ow3ktybIoQSxbcBo28nA/Gzg5NFGVkkqfOkH2xtS6V0K/WjzsrloBHCPFiKp2 yHpXfKubxl8yefQPTMj8hLwlBKrNiN1fz5/629TIkEwDwrUwHxQreE7FAzPMqHORwkYEGBEC AAYFAjyDmkAACgkQb2iPiv4Uz4cnuQCfX1zNrahRTWz/HRpF7ms8qZqzdOIAn1uuu6Jst43p DzanBHUOBzUP6ymA Organization: FreeBSD, Inc. Message-ID: <333774c1-c120-2582-9a60-1b1c784cdd5b@freebsd.org> Date: Mon, 21 May 2018 11:57:36 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180515140351.oyfapiqygprxomvq@ogg.in.absolight.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5QMqpgvAr1eV0Q6ADeVKU0zOyW6JxKFCQ" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 15:57:50 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5QMqpgvAr1eV0Q6ADeVKU0zOyW6JxKFCQ Content-Type: multipart/mixed; boundary="PtdV5M5O1tyHVERCbZCcdUhb2Fao5iIH9"; protected-headers="v1" From: Joe Marcus Clarke To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <333774c1-c120-2582-9a60-1b1c784cdd5b@freebsd.org> Subject: Re: svn commit: r469754 - in head/ports-mgmt/portlint: . src References: <201805121859.w4CIx8jx035047@repo.freebsd.org> <20180515140351.oyfapiqygprxomvq@ogg.in.absolight.net> In-Reply-To: <20180515140351.oyfapiqygprxomvq@ogg.in.absolight.net> --PtdV5M5O1tyHVERCbZCcdUhb2Fao5iIH9 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/15/18 10:03, Mathieu Arnold wrote: > On Sat, May 12, 2018 at 06:59:08PM +0000, Joe Marcus Clarke wrote: >> if ($m{'fla'} ne '${PY_FLAVOR}') { >> - &perror("FATAL", $file, -1, "directory for dependency ". >> - "$m{'dep'} must be $m{'dir'}:\@\${PY_FLAVOR}"); >> + &perror("WARN", $file, -1, "you may want directory for ". >> + "dependency $m{'dep'} to be $m{'dir'}:\@\${PY_FLAVOR}"); >> } >> } else { >> if ($m{'fla'} ne '${FLAVOR}') { >> - &perror("FATAL", $file, -1, "directory for dependency ". >> - "$m{'dep'} must be $m{'dir'}:\@\${FLAVOR}"); >> + &perror("WARN", $file, -1, "you may want directory for ". >> + "dependency $m{'dep'} to be $m{'dir'}:\@\${FLAVOR}"); >=20 > Could you please only tell people to use PY_FLAVOR? Using FLAVOR > directly dates back from when I was implementing the Python flavors and= > is a bad idea. >=20 Does this look right: diff -u -r1.463 portlint.pl --- portlint.pl 12 May 2018 22:12:18 -0000 1.463 +++ portlint.pl 21 May 2018 15:57:25 -0000 @@ -1149,18 +1149,9 @@ # check Python flavor my $bdir =3D basename($m{'dir'}); if ($bdir =3D~ /^py-/) { - if (!defined($makevar{USE_PYTHON}) || - $makevar{USE_PYTHON} eq 'noflavors' || - $makevar{USE_PYTHON} eq '') { - if ($m{'fla'} ne '${PY_FLAVOR}') { - &perror("WARN", $file, -1, "you may want directory for ". - "dependency $m{'dep'} to be $m{'dir'}:\@\${PY_FLAVOR}"); - } - } else { - if ($m{'fla'} ne '${FLAVOR}') { - &perror("WARN", $file, -1, "you may want directory for ". - "dependency $m{'dep'} to be $m{'dir'}:\@\${FLAVOR}"); - } + if ($m{'fla'} ne '${PY_FLAVOR}') { + &perror("WARN", $file, -1, "you may want directory for ". + "dependency $m{'dep'} to be $m{'dir'}:\@\${PY_FLAVOR}"); } } Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --PtdV5M5O1tyHVERCbZCcdUhb2Fao5iIH9-- --5QMqpgvAr1eV0Q6ADeVKU0zOyW6JxKFCQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTMiWQHc8wChijkr7lvaI+K/hTPhwUCWwLscwAKCRBvaI+K/hTP h9sBAJ90tX813P35z0oXYMuxYYj9ytE4owCgjGijg/iYyBGm/pnPI6e0bZILCfE= =U2/J -----END PGP SIGNATURE----- --5QMqpgvAr1eV0Q6ADeVKU0zOyW6JxKFCQ--