Date: Wed, 14 Dec 2011 16:00:15 -0500 From: Wesley Shields <wxs@FreeBSD.org> To: Michael Scheidell <michael.scheidell@secnap.com> Cc: Ryan Steinmetz <zi@FreeBSD.org>, Michael Scheidell <scheidell@FreeBSD.org>, "cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org>, "ports-committers@FreeBSD.org" <ports-committers@FreeBSD.org>, "gabor@FreeBSD.org" <gabor@FreeBSD.org>, "cvs-ports@FreeBSD.org" <cvs-ports@FreeBSD.org> Subject: Re: cvs commit: ports/net-mgmt/net-snmp Makefile Message-ID: <20111214210015.GA13957@atarininja.org> In-Reply-To: <c2c22665-79b0-45a0-a28a-cb942a20d265@blur> References: <1ac141b1-6c9f-4023-90f7-270831c9e989@blur> <c2c22665-79b0-45a0-a28a-cb942a20d265@blur>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 14, 2011 at 08:49:40PM +0000, Michael Scheidell wrote: > Pr logs show pings were made. > Timeout was well past conventional 14 days with no response . > > Sorry but all indications were that noone was working in the port. I don't see anything in the log that indicates zi@ was ever brought in on this discussion before committing. AFAICT the PR was never assigned to him. The PR may have looked stalled but a courtesy "ping" to the current maintainer asking for a quick review would have been the right thing to do, along with recording that in the PR audit trail. Technically speaking zi@ should have grabbed this PR when he became maintainer of this port. As a new committer you may not be familiar with the cultural norms most committers adhere to, but I believe it is the norm to try to contact a current maintainer of a port before committing, especially so if there is no evidence in the audit trail that he/she is working on it. They may be working in private and can help you out before you step into this mess. > As for Python bindings if the default is off it would not have made > those attempts anyway. You can tell your tinderbox to build with custom options. Even if you don't have a tinderbox you should test new options thoroughly. There are plenty of ways to detect the problems this caused. > Back it out and reopen the pr or leave it clised As the one who committed the problem it is, culturally speaking, your responsibility to back it out and work with the requester to find an acceptable solution. -- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111214210015.GA13957>