Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 26 Oct 2003 19:36:39 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Tim Kientzle <kientzle@acm.org>
Cc:        Peter Wemm <peter@FreeBSD.org>
Subject:   Re: cvs commit: src/usr.bin/chat Makefile
Message-ID:  <20031026193034.S17872@gamplex.bde.org>
In-Reply-To: <3F9B6EB1.5020705@acm.org>
References:  <200310260449.h9Q4nwm9016893@repoman.freebsd.org> <20031026171515.P17272@gamplex.bde.org> <3F9B6EB1.5020705@acm.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 25 Oct 2003, Tim Kientzle wrote:

> > On Sat, 25 Oct 2003, Peter Wemm wrote:
> >>peter       2003/10/25 21:49:58 PDT
> >>
> >>  FreeBSD src repository
> >>
> >>  Modified files:
> >>    usr.bin/chat         Makefile
> >>  Log:
> >>  The math function logf() probably isn't doing us much good for logging
> >>  stuff.  Add -fno-builtin-logf.
>
> Rather than commit ugly Makefile hacks like
> this, just rename the damned function and
> be done with it.

Hmm.  logf() is an extern function so it was reserved in C90.  Oherwise
there is nothing wrong with its name.  Making it static would fix the
immediate problem.  The gcc bug doesn't show up until WARNS >=4 gives
-Wshadow.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031026193034.S17872>