From owner-svn-ports-head@FreeBSD.ORG  Tue Jul  9 01:18:38 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 88F467BF; Tue,  9 Jul 2013 01:18:38 +0000 (UTC)
Date: Tue, 9 Jul 2013 01:18:38 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Subject: Re: svn commit: r322444 - head/Tools/scripts
Message-ID: <20130709011838.GA7501@FreeBSD.org>
References: <201307071532.r67FWZTH036372@svn.freebsd.org>
 <51D98A76.7090505@FreeBSD.org>
 <CAF6rxg=UWEC+sn6SU4-7nipODxK83LQteQi-3F6a9dr-DM3yeA@mail.gmail.com>
 <51DB0777.8080300@FreeBSD.org>
 <CAF6rxgkE4bJ+z3miKkDUrJqCgtetgJFX=qHv4M6=M7D9mKbuXQ@mail.gmail.com>
 <08cbb4c709544cad3671c093558910bb@mail.adamw.org>
 <51DB2DB9.1070104@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51DB2DB9.1070104@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org,
 Eitan Adler <eadler@freebsd.org>, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org, Adam Weinberger <adamw@adamw.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jul 2013 01:18:38 -0000

On Mon, Jul 08, 2013 at 04:23:05PM -0500, Bryan Drewery wrote:
> On 7/8/2013 4:12 PM, Adam Weinberger wrote:
> >> A few options with no preference for any particular one:
> >> (a) Mk/ even though it isn't actually a .mk file.
> >> (b) Tools/infrastructure is also okay.
> >> (c) as part of the d4p tarball / port
> >>
> >> Tools/scripts is primarily third party utilities so its not as obvious
> >> that there are critical files in the directory.
> > 
> > Agreed, if I were to check out a "minimal" tree I would not think to
> > include Tools.
> > I'd think Mk/ would be a good place for it---checking out Mk/ should
> > give you all the
> > pieces you need, and dialog4ports.sh is now a critical part of the ports
> > build system.

So is d4p port itself.  Why not just bundle it there?  Mk/ is not really for
helper shell scripts, even critical ones.

> Tools/ also includes required scripts for building INDEX. You would also
> need Templates/ from the root to build ports. This is not new. People
> should be more careful when removing scripts marked as
> portmgr-maintained, modifying files maintained by others, etc.

I would either leave it under Tools/, or moved inside d4p (port or its
distfile).  Tools/infrastructure/ looks too overengineered to me, its like
solving a problem that is actually not a problem. ;-)

./danfe