Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Jul 2016 06:33:25 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 210450] [NEW PORT] devel/liteide: Simple, open source, cross-platform Go IDE
Message-ID:  <bug-210450-13-e4CGlQ0WZH@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-210450-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-210450-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210450

--- Comment #8 from Jan Beich <jbeich@FreeBSD.org> ---
Created attachment 172301
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172301&action=
=3Dedit
minor style changes

The following is bogus

  QT5_USE=3D      ... gl

and should be

  QT5_USE=3D      ... GL=3Dgl

or removed by adding

  LDFLAGS+=3D     -Wl,--as-needed

-lGL seems to be pulled by QtGui.

------------------

USE_QT5=3Dwebkit is unused according to *-qt5.log

   0x00000001 (NEEDED)                     Shared library: [libQt5Core.so.5]
   0x00000001 (NEEDED)                     Shared library: [libQt5Gui.so.5]
   0x00000001 (NEEDED)                     Shared library: [libQt5Network.s=
o.5]
   0x00000001 (NEEDED)                     Shared library:
[libQt5PrintSupport.so.5]
   0x00000001 (NEEDED)                     Shared library: [libQt5Widgets.s=
o.5]
   0x00000001 (NEEDED)                     Shared library: [libQt5Xml.so.5]

However, liteidex/src/plugins/webkithtmlwidget/webkithtmlwidget.pro actually
supports it

  greaterThan(QT_MAJOR_VERSION, 4) {
  QT +=3D webkitwidgets
  } else {
  QT +=3D network
  QT +=3D webkit
  }

but disabled by liteidex/liteidex.pri

  linux* {
      contains(CONFIG, liteide_qtwebkit) {
          DEFINES +=3D LITEIDE_QTWEBKIT
      }
  } else {
      greaterThan(QT_MAJOR_VERSION, 4) {
      } else {
          DEFINES +=3D LITEIDE_QTWEBKIT
      }
  }

(In reply to Dmitri Goutnik from comment #6)
> Jan, I'm not quite sure what you mean by visually confusuing but I
> looked at other ports that have QT4/QT5 as build options and
> rearranged USEs a bit.

Options and their helpers generally go at the bottom just before conditiona=
ls
and target definitions. I'm attaching a patch to illustrate but the last wo=
rd
is up to you, the maintainer.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210450-13-e4CGlQ0WZH>