From owner-svn-src-head@FreeBSD.ORG Sat Jul 19 22:45:05 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A3C17BCE; Sat, 19 Jul 2014 22:45:05 +0000 (UTC) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 719ED2623; Sat, 19 Jul 2014 22:45:04 +0000 (UTC) Received: from c-50-155-136-3.hsd1.co.comcast.net ([50.155.136.3] helo=ilsoft.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1X8dNH-000CwW-PG; Sat, 19 Jul 2014 22:45:04 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id s6JMj2HN028128; Sat, 19 Jul 2014 16:45:02 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.155.136.3 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19CwDxQjQAM2iNnmqUhTQSZ X-Authentication-Warning: paranoia.hippie.lan: Host revolution.hippie.lan [172.22.42.240] claimed to be [172.22.42.240] Subject: Re: svn commit: r268877 - head/share/mk From: Ian Lepore To: Adrian Chadd In-Reply-To: References: <201407191426.s6JEQ4en083862@svn.freebsd.org> <1405805007.85788.24.camel@revolution.hippie.lan> Content-Type: text/plain; charset="ISO-8859-1" Date: Sat, 19 Jul 2014 16:45:02 -0600 Message-ID: <1405809902.85788.39.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by ilsoft.org id s6JMj2HN028128 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 22:45:05 -0000 On Sat, 2014-07-19 at 15:19 -0700, Adrian Chadd wrote: > On 19 July 2014 14:23, Ian Lepore wrote: > > On Sat, 2014-07-19 at 14:26 +0000, Dag-Erling Sm=F8rgrav wrote: > >> Author: des > >> Date: Sat Jul 19 14:26:04 2014 > >> New Revision: 268877 > >> URL: http://svnweb.freebsd.org/changeset/base/268877 > >> > >> Log: > >> Use -o (output to file) instead of -t (print to stdout) and a redi= rect. > >> > >> MFC after: 1 week > >> > >> Modified: > >> head/share/mk/bsd.dep.mk > >> > >> Modified: head/share/mk/bsd.dep.mk > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/share/mk/bsd.dep.mk Sat Jul 19 14:10:31 2014 (r2688= 76) > >> +++ head/share/mk/bsd.dep.mk Sat Jul 19 14:26:04 2014 (r2688= 77) > >> @@ -82,7 +82,7 @@ ${_S:R}.o: ${_S} > >> .for _LSRC in ${SRCS:M*.l:N*/*} > >> .for _LC in ${_LSRC:R}.c > >> ${_LC}: ${_LSRC} > >> - ${LEX} -t ${LFLAGS} ${.ALLSRC} > ${.TARGET} > >> + ${LEX} ${LFLAGS} -o ${.TARGET} ${.ALLSRC} > >> .if !exists(${.OBJDIR}/${DEPENDFILE}) > >> ${_LC:R}.o: ${_LC} > >> .endif > >> > > > > This change breaks the ability to bootstrap from versions prior to 10= .0 > > because the older lex requires "-ofilename" rather than "-o filename". > > Even more annoying, it's not possible to fix it by building the new l= ex > > earlier in bootstrap because the new lex requires a newer m4 be built > > first, and building the new m4 requires running this rule which doesn= 't > > work with the old lex. Grrrr. > > > > It seems like the path of least resistance would be to remove the spa= ce > > between -o and ${TARGET}, which I'll leave for you if you agree, so t= hat > > you can MFC them together when the time comes. >=20 > Hm, why not build lex as a bootstrap tool then, or is this too early > in the process? >=20 >=20 > -a >=20 >=20 Lex is a bootstrap tool and so is m4 and they're interdependant: Lex invokes m4 and pipes data through it, and it does so using command args that don't exist in old versions of m4, so the new m4 has to exist before the new lex will work. But building m4 requires lex, so it has to be possible to build m4 with the old lex before you can use the new lex. -- Ian