Date: Sun, 10 Aug 2014 12:40:10 -0400 From: Adam Weinberger <adamw@adamw.org> To: Marcus von Appen <mva@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r364518 - in head: accessibility/py-papi audio/py-al devel/py-astroid devel/py-dynrules devel/py-game devel/py-logilab-common devel/py-ocempgui devel/py-ply devel/py-sdl2 devel/pychecke... Message-ID: <A70D216E-DF96-4144-82A1-98400D1EB1A9@adamw.org> In-Reply-To: <20140810155649.GA1040@medusa.sysfault.org> References: <53e7336d.2c4d.2257f090@svn.freebsd.org> <20140810095516.GA35955@FreeBSD.org> <2556564.WKGpsAPjlp@mercury.ph.man.ac.uk> <20140810155649.GA1040@medusa.sysfault.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 Aug, 2014, at 11:56, Marcus von Appen <mva@FreeBSD.org> wrote: > On, Sun Aug 10, 2014, Max Brazhnikov wrote: >=20 >> On Sun, 10 Aug 2014 09:55:16 +0000 Alexey Dokuchaev wrote: >>> On Sun, Aug 10, 2014 at 08:55:08AM +0000, Marcus von Appen wrote: >>>> New Revision: 364518 >>>> URL: http://svnweb.freebsd.org/changeset/ports/364518 >>>> QAT: https://qat.redports.org/buildarchive/r364518/ >>>>=20 >>>> -USES=3D pkgconfig >>>> +USES=3D pkgconfig python:2 >>>> USE_GNOME=3D atk >>>> -USE_PYTHON=3D 2 >>>> -USE_PYDISTUTILS=3Dyes >>>> -PYDISTUTILS_AUTOPLIST=3D yes >>>> +PYTHON_FEATURES=3Dautoplist distutils >>>=20 >>> Yuck, this PYTHON_FEATURES knob is ugly. Why not follow Perl's = example >>> instead (USES=3Dperl and USE_PERL)? It both makes more sense and = shorter. >>=20 >> ugly or not, it's a matter of taste. But PYTHON_FEATURES usage is = inconsistent >> with COMPILER_FEATURES (read only var). Could we rename it while it's = not too late? >=20 > Using USE_PYTHON is a problem, since this would be inconsistent with = many > other parts of the infrastructure. Aside from that, it would need a = lot of > glue code for the transition phase. >=20 > Regardless of that, if portmgr's common suggestion is that = XXX_FEATURES is > about testing for a certain feature (read-only), I'm fine with it and = open for > suggestions, which describe that infrastructure bit X wants to enable = a > certain infrastructure feature. >=20 > PYTHON_FEATURES is in my opinion the best by far. If the consensus is = to use > USE_PYTHON, similar to USE_PERL5, this will require us to migrate all = python > ports from USE_PYTHON to USES=3Dpython first and will take some time. Can it just treat USE_PTYHON as PYTHON_FEATURES if USES=3Dpython is = defined? # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A70D216E-DF96-4144-82A1-98400D1EB1A9>