Date: Thu, 6 Dec 2007 13:47:43 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Max Khon <fjoe@samodelkin.net> Cc: src-committers@freebsd.org, John Baldwin <jhb@freebsd.org>, cvs-src@freebsd.org, cvs-all@freebsd.org, John Birrell <jb@freebsd.org>, Dag-Erling Sm??rgrav <des@des.no> Subject: Re: cvs commit: src/sys/netinet/libalias alias_util.c Message-ID: <20071206134743.GA57446@FreeBSD.org> In-Reply-To: <4755BC3B.9040809@samodelkin.net> References: <200711232356.lANNu3mp040885@repoman.freebsd.org> <864pezer7f.fsf@ds4.des.no> <200712031657.34074.jhb@freebsd.org> <20071204172535.GB82261@FreeBSD.org> <4755BC3B.9040809@samodelkin.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 05, 2007 at 02:44:43AM +0600, Max Khon wrote: > Ho! > > Alexey Dokuchaev wrote: > > >>>John Birrell <jb@FreeBSD.org> writes: > >>>> Log: > >>>> Fix strict alias warnings. > >>>A much simpler solution (relative to the previous revision): > >>> > >>>@@ -131,10 +131,10 @@ > >>> sum += oddbyte; > >>> } > >>> /* "Pseudo-header" data */ > >>>- ptr = (u_short *) & (pip->ip_dst); > >>>+ ptr = (void *)&pip->ip_dst; > >>> sum += *ptr++; > >>> sum += *ptr; > >>>- ptr = (u_short *) & (pip->ip_src); > >>>+ ptr = (void *)&pip->ip_src; > >>> sum += *ptr++; > >>> sum += *ptr; > >>> sum += htons((u_short) ntcp); > >>*ptr++ would choke since pointer arith on (void *) is undefined AFAIK. > > > >I've been under impression that ++ on void * whould simply increase it > >by one. > > Nope. Read man 1 gcc about -Wpointer-arith Right, I stand corrected. I've been thinking that ++/-- is kinda special. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071206134743.GA57446>