From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Apr 30 18:40:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 64104EF3 for ; Tue, 30 Apr 2013 18:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 3BB7A12D8 for ; Tue, 30 Apr 2013 18:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3UIe19E005647 for ; Tue, 30 Apr 2013 18:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3UIe15W005646; Tue, 30 Apr 2013 18:40:01 GMT (envelope-from gnats) Date: Tue, 30 Apr 2013 18:40:01 GMT Message-Id: <201304301840.r3UIe15W005646@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Hiroki Sato Subject: Re: ports/178250: Fix build failures of japanese/{mozc-server, mozc-tool, ibus-mozc, mozc-el} X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Hiroki Sato List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2013 18:40:01 -0000 The following reply was made to PR ports/178250; it has been noted by GNATS. From: Hiroki Sato To: abtk@shitamachi.org Cc: freebsd-gnats-submit@FreeBSD.org, hrs@FreeBSD.org Subject: Re: ports/178250: Fix build failures of japanese/{mozc-server, mozc-tool, ibus-mozc, mozc-el} Date: Wed, 01 May 2013 03:36:08 +0900 (JST) ----Security_Multipart(Wed_May__1_03_36_08_2013_641)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Tadaaki Nagao wrote in <20130501.012308.420345141091390850.abtk@shitamachi.org>: ab> When I wrote the patch I previously sent, my intention was to preserve ab> original code as much as possible. As for why they were so written in ab> the first place, please ask the original author... (daichi-san?) I am also not sure why, but they simply shouldn't have been committed. The previous change is fairly broken as you noticed. We do not have to preserve the wrong part. ab> But I agree with you that those BUILD_DEPENDS should be got rid of in ab> favor of some other preferable ways. I will look into this, but it will ab> take some time because Mozc's build system looks to me too complicated ab> to understand. In the meanwhile, how about applying my patch as a quick ab> fix for the current breakage, and having refinements later as a second ab> step. I already submitted a similar fix. Can you review it? http://people.allbsd.org/~hrs/FreeBSD/mozc_port_20130428-2.diff (patch) http://people.allbsd.org/~hrs/FreeBSD/mozc_port_full_20130428-2.tar.gz (tarball of the patched ports) Although I received a build error report in some environment and still investigating it, this should fix wrong parts (including style clean-ups) as far as I can see. -- Hiroki ----Security_Multipart(Wed_May__1_03_36_08_2013_641)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlGADxgACgkQTyzT2CeTzy3ibgCfT1MCo+6nd7reFluTXkPqzu1z cFkAoKSdpPQjATaj2eHG4ArNqDJukbXV =u58M -----END PGP SIGNATURE----- ----Security_Multipart(Wed_May__1_03_36_08_2013_641)----