From owner-freebsd-current@FreeBSD.ORG Sat Nov 11 02:09:41 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A593416A415 for ; Sat, 11 Nov 2006 02:09:41 +0000 (UTC) (envelope-from pawel.worach@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB31843D58 for ; Sat, 11 Nov 2006 02:09:40 +0000 (GMT) (envelope-from pawel.worach@gmail.com) Received: by ug-out-1314.google.com with SMTP id o2so625286uge for ; Fri, 10 Nov 2006 18:09:39 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=FWW4uS7ZZ73uJbT6tVy6qrFRvFNl9yK+ua/u7XTStWO5oeJsKJQfOEl0ZD00yNnNkUCNW2WRluPGpw89nrlMITsLwOu1LnYV2bJo5BxtSXkk6jYPXN776Jcf/H+8XY4Iho1Kk4UjsYIQOyU0Jw4jwqheTev0nNDJbPHH4gOW4a8= Received: by 10.66.232.11 with SMTP id e11mr4376929ugh.1163210979402; Fri, 10 Nov 2006 18:09:39 -0800 (PST) Received: from ?192.168.1.200? ( [80.217.194.157]) by mx.google.com with ESMTP id o24sm3132956ugd.2006.11.10.18.09.38; Fri, 10 Nov 2006 18:09:38 -0800 (PST) Message-ID: <455530E0.5090000@gmail.com> Date: Sat, 11 Nov 2006 03:09:36 +0100 From: Pawel Worach User-Agent: Thunderbird 1.5.0.7 (X11/20061109) MIME-Version: 1.0 To: Andre Oppermann References: <200611021653.kA2GrRWx008044@repoman.freebsd.org> In-Reply-To: <200611021653.kA2GrRWx008044@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: sendfile data corruption (was: cvs commit: src/sys/kern uipc_syscalls.c src/sys/sys libkern.h socket.h) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Nov 2006 02:09:41 -0000 Andre Oppermann wrote: > andre 2006-11-02 16:53:26 UTC > > FreeBSD src repository > ... > Rewrite kern_sendfile() to work in two loops, the inner which turns as many ... > > Revision Changes Path > 1.240 +280 -242 src/sys/kern/uipc_syscalls.c > 1.55 +2 -0 src/sys/sys/libkern.h > 1.91 +2 -1 src/sys/sys/socket.h Hi Andre, I'm seeing some strange data corruption with this change. Using apache 2.0.59 from ports, hardware is SMP i386. 0>root@cookie /usr/local/www/data# md5 sh MD5 (sh) = e090ae9fc697b6ec84165af920034dc4 0>root@cookie /usr/local/www/data# unsetenv http_proxy 0>root@cookie /usr/local/www/data# fetch -o /tmp/sh http://127.0.0.1/sh /tmp/sh 100% of 109 kB 6516 kBps 0>root@cookie /usr/local/www/data# md5 /tmp/sh MD5 (/tmp/sh) = 1b6b9786ce7aa74b7ecbc7ee82c230dd It seems to be consistent... 0>root@zero /usr/local/www/data# fetch -o /tmp/sh2 http://127.0.0.1/sh /tmp/sh2 100% of 109 kB 41 MBps 0>root@zero /usr/local/www/data# md5 /tmp/sh2 MD5 (/tmp/sh2) = 1b6b9786ce7aa74b7ecbc7ee82c230dd Checking with hd(1) the changed data always seems to start at offset 0x0000e000. cvs up -D '2006/11/02 17:00:00' OK Repository revision: 1.239 /export/ctm/cvs/src/sys/kern/uipc_syscalls.c,v cvs up -D '2006/11/02 18:00:00' BROKEN Repository revision: 1.240 /export/ctm/cvs/src/sys/kern/uipc_syscalls.c,v Files changed with update: P geom/journal/g_journal.c P kern/uipc_syscalls.c P sys/libkern.h P sys/socket.h Any other information I can provide? Regards -- Pawel