From owner-cvs-all Sat Aug 14 5: 1:18 1999 Delivered-To: cvs-all@freebsd.org Received: from ns1.yes.no (ns1.yes.no [195.204.136.10]) by hub.freebsd.org (Postfix) with ESMTP id 1F85B14C2D; Sat, 14 Aug 1999 05:01:10 -0700 (PDT) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.9.1a/8.9.1) with ESMTP id OAA06412; Sat, 14 Aug 1999 14:01:27 +0200 (CEST) Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id OAA32616; Sat, 14 Aug 1999 14:01:26 +0200 (MET DST) Date: Sat, 14 Aug 1999 14:01:26 +0200 From: Eivind Eklund To: Chris Costello Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/test test.c Message-ID: <19990814140126.D24270@bitbox.follo.net> References: <199908140538.WAA71599@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.1i In-Reply-To: <199908140538.WAA71599@freefall.freebsd.org>; from Chris Costello on Fri, Aug 13, 1999 at 10:38:06PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Fri, Aug 13, 1999 at 10:38:06PM -0700, Chris Costello wrote: > chris 1999/08/13 22:38:06 PDT > > Modified files: > bin/test test.c > Log: > Minor style fix - change 'if(!*v)' to 'if (!*v)' Talking of test - I think we should replace our test with the version in NetBSD/OpenBSD. It is a total re-implementation with cleaner code and a couple of more primitives (which also would let us use parts from the OpenBSD and NetBSD /etc scripts, which would also be a benefit). The replacement compiles and works cleanly on FreeBSD; I've run with it for a while, and have never seen any problem (but I haven't been trying to create problems, either - I've just used it normally). Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message