From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jul 13 06:20:10 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9AD0337B401 for ; Sun, 13 Jul 2003 06:20:10 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A254F43F75 for ; Sun, 13 Jul 2003 06:20:09 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h6DDK9Up066569 for ; Sun, 13 Jul 2003 06:20:09 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h6DDK9Hn066568; Sun, 13 Jul 2003 06:20:09 -0700 (PDT) Resent-Date: Sun, 13 Jul 2003 06:20:09 -0700 (PDT) Resent-Message-Id: <200307131320.h6DDK9Hn066568@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Melvyn Sopacua Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8AB2E37B401; Sun, 13 Jul 2003 06:18:46 -0700 (PDT) Received: from ghost.lan.webteckies.org (node123e0.a2000.nl [24.132.35.224]) by mx1.FreeBSD.org (Postfix) with ESMTP id 49DC243FBF; Sun, 13 Jul 2003 06:18:45 -0700 (PDT) (envelope-from root@webteckies.org) Received: by ghost.lan.webteckies.org (Postfix, from userid 0) id D533021BB8; Sun, 13 Jul 2003 15:18:30 +0200 (CEST) Message-Id: <20030713131830.D533021BB8@ghost.lan.webteckies.org> Date: Sun, 13 Jul 2003 15:18:30 +0200 (CEST) From: Melvyn Sopacua To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: MAINTAINER Subject: ports/54435: [PATCH] multimedia/libdvdread dvdcss_crack symbol revisited X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jul 2003 13:20:11 -0000 >Number: 54435 >Category: ports >Synopsis: [PATCH] multimedia/libdvdread dvdcss_crack symbol revisited >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jul 13 06:20:08 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Melvyn Sopacua >Release: FreeBSD 4.8-STABLE i386 >Organization: >Environment: System: FreeBSD ghost.lan.webteckies.org 4.8-STABLE FreeBSD 4.8-STABLE #0: Sat Jul 5 18:39:46 CEST 2003 root@ghost.lan.webteckies.org:/usr/obj/usr/src/sys/GHOST i386 >Description: When using transcode with divx[45] or xvid encoding, the following message is generated: Undefined symbol "dvdcss_crack"Failed to init XviD codec[transcode] warning : (encoder.c) video export module error: init failed I've done some fair ammount of testing, like: find /usr/local/lib -name "*.so" -print | while read LIB; do nm $LIB | grep 'dvdcss_crack' ; done for DIR in libdvdcss libdvdnav libdvdplay libdvdread xvid libdivxdecore libdivxencore transcode ; do (cd $DIR && make patch) ; done ; find . -type f -print | xargs grep dvdcss_crack The only reference found, was the assertion in dvd_input.c, from libdvdread, which assumes that if the dlsym works, there's an undefined symbol. This was already pointed out by Hendrik Scholz in: After removing the assertion, things work correctly. >How-To-Repeat: Use DVD::Rip to transcode a dvd with divx[45] or xvid encoding. >Fix: Add the following 'patch-dvdread::dvd_input.c' to files/ --- dvdread/dvd_input.c.orig Sun Jul 13 14:42:27 2003 +++ dvdread/dvd_input.c Sun Jul 13 14:42:41 2003 @@ -297,14 +297,7 @@ dvdcss_version = (char **)dlsym(dvdcss_library, U_S "dvdcss_interface_2"); - if(dlsym(dvdcss_library, U_S "dvdcss_crack")) { - fprintf(stderr, - "libdvdread: Old (pre-0.0.2) version of libdvdcss found.\n" - "libdvdread: You should get the latest version from " - "http://www.videolan.org/\n" ); - dlclose(dvdcss_library); - dvdcss_library = NULL; - } else if(!DVDcss_open || !DVDcss_close || !DVDcss_title || !DVDcss_seek + if(!DVDcss_open || !DVDcss_close || !DVDcss_title || !DVDcss_seek || !DVDcss_read || !DVDcss_error || !dvdcss_version) { fprintf(stderr, "libdvdread: Missing symbols in libdvdcss.so.2, " "this shouldn't happen !\n"); >Release-Note: >Audit-Trail: >Unformatted: