Date: Tue, 26 Feb 2019 02:53:40 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 236038] [NEW PORT] net-mgmt/py-nxapi_plumbing: Manage Cisco Nexus via JSON-RPC and XML Message-ID: <bug-236038-7788-tMUQKXOljD@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-236038-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-236038-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236038 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|easy, patch, patch-ready |feature Status|New |Open --- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> --- Thanks John, Review items:=20 - Minor: Match a projects upstream description (setup.py:description) as closely as possible, with COMMENT (portlint) compliance changes where necessary. In this case "Library for managing Cisco devices through NX-API using XML or jsonrpc" - Projects setup.py:url is a 404, can you send an upstream issue/PR to corr= ect it - sdist includes tests and a test command (in tox.ini not shipped in sdist). Add TEST_DEPENDS (pytest) and a do(test) target for QA. The following should work: do-test: @cd ${WRKSRC}} && ${PYTHON_CMD} -m pytest -v -s test Would be great to confirm those tests pass as well --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-236038-7788-tMUQKXOljD>