Date: Thu, 10 Mar 2011 18:41:22 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Martin Wilke <miwi@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, John Hein <jhein@symmetricom.com>, john.c.prather@gmail.com, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/davmail Makefile distinfo pkg-plist ports/mail/davmail/files davmail.in davmail.properties.sample davmail.sh.in Message-ID: <4D798BD2.2030400@FreeBSD.org> In-Reply-To: <201103091401.p29E1mtM086605@repoman.freebsd.org> References: <201103091401.p29E1mtM086605@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Couple of comments on the rc.d script: 1. The %%PORTNAME%% obfuscation isn't worth the effort. It doesn't have any good benefits that make it worth causing the difficulty in reading the script in the tree. 2. If the script starts a persistent service (which it seems to) it needs "KEYWORD: SHUTDOWN" 3. procname probably wants to be command_interpreter, but that should be tested. hth, Doug On 03/09/2011 06:01, Martin Wilke wrote: > miwi 2011-03-09 14:01:48 UTC > > FreeBSD ports repository > > Modified files: > mail/davmail Makefile distinfo pkg-plist > mail/davmail/files davmail.sh.in > Added files: > mail/davmail/files davmail.in davmail.properties.sample > Log: > - Update to 3.9.0 > > PR: 154982 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=154982 > Submitted by: John Hein<jhein@symmetricom.com> > Approved by: maintainer > > Revision Changes Path > 1.3 +19 -11 ports/mail/davmail/Makefile > 1.3 +2 -2 ports/mail/davmail/distinfo > 1.1 +43 -0 ports/mail/davmail/files/davmail.in (new) > 1.1 +34 -0 ports/mail/davmail/files/davmail.properties.sample (new) > 1.2 +3 -2 ports/mail/davmail/files/davmail.sh.in > 1.3 +3 -0 ports/mail/davmail/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/Makefile.diff?&r1=1.2&r2=1.3&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/distinfo.diff?&r1=1.2&r2=1.3&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/files/davmail.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/files/davmail.properties.sample > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/files/davmail.sh.in.diff?&r1=1.1&r2=1.2&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/davmail/pkg-plist.diff?&r1=1.2&r2=1.3&f=h > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D798BD2.2030400>