From owner-freebsd-current  Sat Jun 29 11:11:27 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id LAA18389
          for current-outgoing; Sat, 29 Jun 1996 11:11:27 -0700 (PDT)
Received: from sc.ZIB-Berlin.DE (sc.ZIB-Berlin.DE [130.73.108.1])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id LAA18384;
          Sat, 29 Jun 1996 11:11:22 -0700 (PDT)
Received: from softs11.ZIB-Berlin.DE by sc.ZIB-Berlin.DE (5.x/SMI-5.3-20.11.95)
	id AA17553; Sat, 29 Jun 1996 20:11:05 +0200
Received: (from wosch@localhost) by campa.panke.de (8.6.12/8.6.12) id UAA01063; Sat, 29 Jun 1996 20:02:28 +0200
Date: Sat, 29 Jun 1996 20:02:28 +0200
From: Wolfram Schneider <wosch@softs11.ZIB-Berlin.DE>
Message-Id: <199606291802.UAA01063@campa.panke.de>
To: Bruce Evans <bde@zeta.org.au>
Cc: freebsd-current@freebsd.org, jhay@mikom.csir.co.za, jkh@freebsd.org,
        wosch@freebsd.org
Subject: Re: make clean in src/lkm problems
In-Reply-To: <199606290927.TAA32420@godzilla.zeta.org.au>
References: <199606290927.TAA32420@godzilla.zeta.org.au>
Reply-To: Wolfram Schneider <wosch@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

Bruce Evans writes:
>This is just a bug in the nesting of the target in *.mk.  bsd.kmod.mk
>doesn't have its own clean target.  It gets a bad one (depending on
>_SUBDIR but not on cleanfiles) by including bsd.dep.mk before including
>bsd.obj.mk.  This breaks cleaning in all lkm directories, independent of
>the existence and location of the obj directories.

Jordan changed the order of the include files in bsd.kmod.mk.
JOOOOOOOOOOOOOOOOOOOOOOORDAAAAAAAAAAAAAAAN!  Why did you do that? The
order is still important. And the order will be important if we move
bsd.own.mk from sys.mk to bsd.*.mk files. Please put bsd.obj.mk before
bsd.dep.mk in bsd.kmod.mk.


>All the other top level bsd.*.mk files avoid this problem by having their
>own `clean' target.  

All except bsd.sgml.mk (remember the problem with undeleted *.html
files). bsd.sgml.mk should not include bsd.dep.mk because
bsd.dep.mk is for `c' sources.


>Complete fix: either remove `clean' targets from included files, or
>define them in only one included file, or use use `clean::' instead of
>`clean:' to allow the rules to accumulate.  The current method of
>defining `clean' targets in included files if the target doesn't already
>exist just breaks things if the files are included in an unfortunate
>order.

My intention was a single 'clean:' target in bsd.obj.mk. Except
if the top makefile (./obj/Makefile, ./Makefile) does 
have their own clean target.


PS: now I have ~200 'obj' trouble mails in my mailbox. Was it that
worth?

Wolfram <wosch@freebsd.org>