From owner-svn-src-head@FreeBSD.ORG  Fri Sep  4 17:46:01 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BD8421065679
	for <svn-src-head@freebsd.org>; Fri,  4 Sep 2009 17:46:01 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outX.internet-mail-service.net (outx.internet-mail-service.net
	[216.240.47.247])
	by mx1.freebsd.org (Postfix) with ESMTP id A31028FC18
	for <svn-src-head@freebsd.org>; Fri,  4 Sep 2009 17:46:01 +0000 (UTC)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id 85B80ADA67;
	Fri,  4 Sep 2009 10:46:01 -0700 (PDT)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id D2C5A2D6006;
	Fri,  4 Sep 2009 10:46:00 -0700 (PDT)
Message-ID: <4AA15257.4050305@elischer.org>
Date: Fri, 04 Sep 2009 10:45:59 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: "Bjoern A. Zeeb" <bz@FreeBSD.org>
References: <200909041453.n84ErCtU075966@svn.freebsd.org>
	<20090904145527.S68375@maildrop.int.zabbadoz.net>
In-Reply-To: <20090904145527.S68375@maildrop.int.zabbadoz.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Konstantin Belousov <kib@FreeBSD.org>
Subject: Re: svn commit: r196829 - head/sys/i386/i386
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Sep 2009 17:46:01 -0000

Bjoern A. Zeeb wrote:
> On Fri, 4 Sep 2009, Konstantin Belousov wrote:
> 
>> Author: kib
>> Date: Fri Sep  4 14:53:12 2009
>> New Revision: 196829
>> URL: http://svn.freebsd.org/changeset/base/196829
>>
>> Log:
>>  Add missing ';'.
> 
> This hadn't been noticed for a year as up to r196810 PCPU_SET was a
>     {
>         ..
>     }
> block. With r196811 it was changed to
>     do {
>         ..
>     } while (0)
> and thus the missing ';' immediately became a syntax error.

so, why does my tree compile?

> 
> 
>> Modified:
>>  head/sys/i386/i386/machdep.c
>>
>> Modified: head/sys/i386/i386/machdep.c
>> ============================================================================== 
>>
>> --- head/sys/i386/i386/machdep.c    Fri Sep  4 11:32:05 2009    (r196828)
>> +++ head/sys/i386/i386/machdep.c    Fri Sep  4 14:53:12 2009    (r196829)
>> @@ -2570,7 +2570,7 @@ init386(first)
>>     default_proc_ldt.ldt_base = (caddr_t)ldt;
>>     default_proc_ldt.ldt_len = 6;
>>     _default_ldt = (int)&default_proc_ldt;
>> -    PCPU_SET(currentldt, _default_ldt)
>> +    PCPU_SET(currentldt, _default_ldt);
>>     PT_SET_MA(ldt, *vtopte((unsigned long)ldt) & ~PG_RW);
>>     xen_set_ldt((unsigned long) ldt, (sizeof ldt_segs / sizeof 
>> ldt_segs[0]));
>>
>>
>