Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 04 Aug 2000 18:43:31 +0300
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        Akinori -Aki- MUSHA <knu@idaemons.org>
Cc:        Ade Lovett <ade@FreeBSD.org>, ports@FreeBSD.org
Subject:   Re: cvs commit: ports/devel/dryad Makefile  ports/devel/dryad/patches         patch-aa patch-ab ports/graphics/eog  Makefile         ports/graphics/eog/patches patch-aa patch-ab  patch-ac         ports/editors/gedit Makefile  ports/editors/gedit/patches patch-ao ...
Message-ID:  <398AE4A3.53284EAF@FreeBSD.org>
References:  <200008040134.SAA73918@freefall.freebsd.org> <86zomtp19w.wl@localhost.local.idaemons.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Akinori -Aki- MUSHA wrote:

> At Thu, 3 Aug 2000 18:34:41 -0700 (PDT),
> aDe wrote:
> >   Extensive patchfile cleanups using sobomax's wonderful
> >   post-extract rule
>
> Hmm.. I think you should use pre-patch or post-patch for that purpose.
> I mean, "extract" stage should only consist of extracting files,
> removing unnecessary files, and creating or copying necessary files,
> when patching and editing files belong in "patch" (or "configure")
> stage.
>
> >From my point of view, "make extract" should just extract the
> distributed files as-is, so one can stand at the start point and look
> around to find out what materials are provided by the vendor(s).  I
> suppose that would help him/her try (another) hacking on it.

Agreed. Then the libtool hack should be moved into pre-patch stage as well
because currently it modifies files after patches has been applied, so you have
to remember it each time you are doing "diff -du configure.orig configure" for
the libtoolish port.

-Maxim




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?398AE4A3.53284EAF>