From owner-freebsd-current@FreeBSD.ORG Thu Oct 27 14:38:08 2005 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78B4516A41F for ; Thu, 27 Oct 2005 14:38:08 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id BDC3743D46 for ; Thu, 27 Oct 2005 14:38:07 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j9REc4qK010571 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 Oct 2005 18:38:05 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j9REc4hv010570; Thu, 27 Oct 2005 18:38:04 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 27 Oct 2005 18:38:04 +0400 From: Gleb Smirnoff To: Peter Holm Message-ID: <20051027143804.GP41520@cell.sick.ru> References: <20051026072337.GA31319@peter.osted.lan> <20051026083147.GA41520@cell.sick.ru> <20051026130926.GA41293@peter.osted.lan> <20051026131423.GH41520@cell.sick.ru> <20051027060916.GA55631@peter.osted.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20051027060916.GA55631@peter.osted.lan> User-Agent: Mutt/1.5.6i Cc: current@FreeBSD.org, mohans@yahoo-inc.com Subject: Re: panic: mutex nfsd_mtx owned at nfsserver/nfs_serv.c:2160 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 14:38:08 -0000 On Thu, Oct 27, 2005 at 08:09:17AM +0200, Peter Holm wrote: P> On Wed, Oct 26, 2005 at 05:14:23PM +0400, Gleb Smirnoff wrote: P> > On Wed, Oct 26, 2005 at 03:09:26PM +0200, Peter Holm wrote: P> > P> > On Wed, Oct 26, 2005 at 09:23:37AM +0200, Peter Holm wrote: P> > P> > P> While stress testing RELENG_6_0 with a nfs mounted file system on a P> > P> > P> box running HEAD from Oct 24 13:21 UTC I got this panic (on HEAD): P> > P> > P> http://people.freebsd.org/~pho/stress/log/nfsd.html P> > P> > P> > P> > let's try out this one. P> > P> > P> > P> P> > P> With this patch I got a (unrelated ?) P> > P> panic: lock (sleep mutex) Giant not locked @ nfsserver/nfs_serv.c:2193 P> > P> > Related. Please try out a corrected patch. P> > P> After running for +15 hours I think that I can conclude that this P> patch has fixed the problem? I think so. Let's ask Mohan to review it. P> - Peter P> > -- P> > Totus tuus, Glebius. P> > GLEBIUS-RIPN GLEB-RIPE P> P> > Index: nfs_serv.c P> > =================================================================== P> > RCS file: /home/ncvs/src/sys/nfsserver/nfs_serv.c,v P> > retrieving revision 1.156 P> > diff -u -r1.156 nfs_serv.c P> > --- nfs_serv.c 17 Apr 2005 16:25:36 -0000 1.156 P> > +++ nfs_serv.c 26 Oct 2005 13:13:25 -0000 P> > @@ -2092,6 +2092,8 @@ P> > tl = nfsm_dissect_nonblock(u_int32_t *, NFSX_UNSIGNED); P> > vtyp = nfsv3tov_type(*tl); P> > if (vtyp != VCHR && vtyp != VBLK && vtyp != VSOCK && vtyp != VFIFO) { P> > + NFSD_UNLOCK(); P> > + mtx_lock(&Giant); /* VFS */ P> > error = NFSERR_BADTYPE; P> > goto out; P> > } P> > @@ -2108,6 +2110,8 @@ P> > * Iff doesn't exist, create it. P> > */ P> > if (nd.ni_vp) { P> > + NFSD_UNLOCK(); P> > + mtx_lock(&Giant); /* VFS */ P> > error = EEXIST; P> > goto out; P> > } -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE