Date: Thu, 21 Jul 2011 15:13:23 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: danfe@FreeBSD.org Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, mandree@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/print/ghostscript9 Makefile ports/print/ghostscript9/files patch-base-gdevl256.c patch-base-gdevvglb.c Message-ID: <20110721.151323.265642678034513451.hrs@allbsd.org> In-Reply-To: <20110721054015.GA72702@FreeBSD.org> References: <201107171118.p6HBIlc6096985@repoman.freebsd.org> <4E22E228.3020303@FreeBSD.org> <20110721054015.GA72702@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Thu_Jul_21_15_13_23_2011_939)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Alexey Dokuchaev <danfe@FreeBSD.ORG> wrote in <20110721054015.GA72702@FreeBSD.org>: da> On Sun, Jul 17, 2011 at 03:22:48PM +0200, Matthias Andree wrote: da> > Am 17.07.2011 13:18, schrieb Hiroki Sato: da> > > hrs 2011-07-17 11:18:47 UTC da> > > da> > > Modified files: da> > > print/ghostscript9 Makefile da> > > Added files: da> > > print/ghostscript9/files patch-base-gdevl256.c da> > > patch-base-gdevvglb.c da> > > Log: da> > > Fix a build failure when vaglib and/or lvga256 is specified. da> > da> > It is very unfortunate that the PORTREVISION was bumped, and wasteful. da> > This was not necessary, let me explain: da> > da> > - if the build fails given specific (apparently non-default) options, da> > there is no prior port/package where files change da> > da> > - we bump PORTREVISION only if installed files or dependencies change. da> da> Even for deps/plist changes, it is not always necessary to bump revision. da> If, for example, port behavior is changed so it installs few extra files, da> PORTREVISION can be left intact, as long as previous version of the port has da> correct plist. On contrast, if pkg-plist was updated to include files that da> were installed but didn't have plist entry before, PORTREVISION should be da> bumped so users can get "fixed" package. da> da> In general, I totally agree with Matthias on this issue: please give enough da> thinking before bumping PORTREVISION. Sorry, I mistakenly thought one of the options was enabled by default for some reason. -- Hiroki ----Security_Multipart(Thu_Jul_21_15_13_23_2011_939)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk4nw4QACgkQTyzT2CeTzy0ECgCePNpe5hCBHuPhKTILFNjcBwHY MXQAn2RW29vZZFccniMU399gBqzHQQLX =Xl3H -----END PGP SIGNATURE----- ----Security_Multipart(Thu_Jul_21_15_13_23_2011_939)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110721.151323.265642678034513451.hrs>