Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 31 Aug 2008 20:01:14 GMT
From:      Nathan Whitehorn <nwhitehorn@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 148931 for review
Message-ID:  <200808312001.m7VK1E5B098115@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=148931

Change 148931 by nwhitehorn@nwhitehorn_trantor on 2008/08/31 20:00:22

	Remove some poorly motivated code in pmap_kremove() that could cause panics and accomplished nothing.

Affected files ...

.. //depot/projects/ppc-g5/sys/powerpc/aim/mmu_oea64.c#3 edit

Differences ...

==== //depot/projects/ppc-g5/sys/powerpc/aim/mmu_oea64.c#3 (text+ko) ====

@@ -1559,26 +1559,6 @@
 void
 moea64_kremove(mmu_t mmu, vm_offset_t va)
 {
-	struct	pvo_entry *pvo;
-	struct	lpte *pt;
-
-	PMAP_LOCK(kernel_pmap);
-	pvo = moea64_pvo_find_va(kernel_pmap, va & ~ADDR_POFF, NULL);
-	KASSERT(pvo != NULL, ("moea64_kextract: no addr found"));
-
-	LOCK_TABLE();
-	pt = moea64_pvo_to_pte(pvo, -1);
-	if (pt != NULL) {
-		moea64_pte_synch(pt, &pvo->pvo_pte.lpte);
-		if (((pvo->pvo_pte.lpte.pte_lo & (LPTE_I | LPTE_G)) == 0)
-		    && (pvo->pvo_pte.lpte.pte_lo & LPTE_CHG)) {
-			__syncicache((void *)va, PAGE_SIZE);
-		}
-	}
-	UNLOCK_TABLE();
-
-	PMAP_UNLOCK(kernel_pmap);
-
 	moea64_remove(mmu, kernel_pmap, va, va + PAGE_SIZE);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808312001.m7VK1E5B098115>