From owner-svn-src-user@FreeBSD.ORG Thu Feb 23 15:38:54 2012 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B3C6106566B; Thu, 23 Feb 2012 15:38:54 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by mx1.freebsd.org (Postfix) with ESMTP id 682C18FC13; Thu, 23 Feb 2012 15:38:53 +0000 (UTC) Received: by wibhn14 with SMTP id hn14so1290919wib.13 for ; Thu, 23 Feb 2012 07:38:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LoHvCZejMD4MxRe83lIDu2tJwHkwnRNbg8auGVuHExs=; b=qKhDswz4TsPCadu1w/IE+Xw+2SRqmVZV7WFr3MFTQ/F0OUGQnLtg4EA47FOs4mue7B /ckozDRALeuI2mHHgxcrYv/aR5rbhBJUpT8kpvXNprDX4OdkDUz60XrGmcb+p2grT2bI 0hE4ZF82lF3wuaYBDGP/FmQX4gE7MTbWOqMK4= MIME-Version: 1.0 Received: by 10.180.109.198 with SMTP id hu6mr3349160wib.16.1330010011508; Thu, 23 Feb 2012 07:13:31 -0800 (PST) Sender: c.jayachandran@gmail.com Received: by 10.216.122.85 with HTTP; Thu, 23 Feb 2012 07:13:31 -0800 (PST) In-Reply-To: References: <201202230536.q1N5anOF086049@svn.freebsd.org> Date: Thu, 23 Feb 2012 20:43:31 +0530 X-Google-Sender-Auth: CVYm2X3RI8pjNf7f_3X-V7dHXyA Message-ID: From: "Jayachandran C." To: Rafal Jaworowski Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r232028 - in user/jchandra/xlp-merge/sys: conf dev/iicbus X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2012 15:38:54 -0000 On Thu, Feb 23, 2012 at 7:42 PM, Rafal Jaworowski wrote: > > On 2012-02-23, at 06:36, Jayachandran C. wrote: > >> Author: jchandra >> Date: Thu Feb 23 05:36:49 2012 >> New Revision: 232028 >> URL: http://svn.freebsd.org/changeset/base/232028 >> >> Log: >> =A0Move driver for DS1374 RTC to sys/dev/iicbus >> >> =A0The earlier version of the driver was sys/mips/rmi/dev/iic/ds1374u.c > > Is the DS1374 very different from other DS13xx chips? > > We have some patches locally that extend the current DS133x into DS13xx i= .e. support also DS1388 for example, so I was wondering if the DS1374 could= be just squeezed in as well? See http://people.freebsd.org/~raj/patches/mi= sc/ds13xx.diff I had a quick look at the datasheets, the 1374 registers uses a time of day counter, while the 133x uses a BCD coded date representation. The other features which we do not support now(alarm/watchdog etc) also seems different, so merging the drivers may not result in reducing code. JC.