From owner-freebsd-emulation@FreeBSD.ORG  Fri Feb 21 18:49:03 2014
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: vbox@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5D5CF6FC;
 Fri, 21 Feb 2014 18:49:03 +0000 (UTC)
Received: from mailrelay009.isp.belgacom.be (mailrelay009.isp.belgacom.be
 [195.238.6.176])
 by mx1.freebsd.org (Postfix) with ESMTP id C164C1FD5;
 Fri, 21 Feb 2014 18:49:02 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AlUGAEKeB1NbsI2W/2dsb2JhbABagwY7S8BJgQ4XdIIlAQEFOhwjEAsYCSUPKh4GE4gJAQjLPBMEjmQHhDgBA5gzkiiDLjs
Received: from 150.141-176-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.176.141.150])
 by relay.skynet.be with ESMTP; 21 Feb 2014 19:48:55 +0100
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.8/8.14.8) with ESMTP id s1LImsgu018617;
 Fri, 21 Feb 2014 19:48:54 +0100 (CET)
 (envelope-from tijl@FreeBSD.org)
Date: Fri, 21 Feb 2014 19:48:53 +0100
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Jung-uk Kim <jkim@FreeBSD.org>
Subject: Re: emulators/virtualbox-ose doesn't compile with libiconv
Message-ID: <20140221194853.277adcb9@kalimero.tijl.coosemans.org>
In-Reply-To: <530796B0.5040100@FreeBSD.org>
References: <20140210191712.728e1b7d@s100.slimaczek.pl>
 <20140221170046.07c87bce@kalimero.tijl.coosemans.org>
 <20140221174251.72fa8e74@kalimero.tijl.coosemans.org>
 <530796B0.5040100@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Fri, 21 Feb 2014 19:01:34 +0000
Cc: vbox@FreeBSD.org
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Development of Emulators of other operating systems
 <freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation/>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Feb 2014 18:49:03 -0000

On Fri, 21 Feb 2014 13:10:56 -0500 Jung-uk Kim wrote:
> On 2014-02-21 11:42:51 -0500, Tijl Coosemans wrote:
>> On Fri, 21 Feb 2014 17:00:46 +0100 Tijl Coosemans wrote:
>>> On Mon, 10 Feb 2014 19:17:12 +0100 Tomasz Sowa wrote:
>>>> emulators/virtualbox-ose doesn't compile when
>>>> converters/libiconv is installed:
>>> 
>>> Please try the attached patch for the port Makefile.
>> 
>> Sorry, that one was incomplete.  This one should work better.
> 
> Actually, I fixed it in my tree little differently.
> 
> https://redports.org/changeset?reponame=&new=23380%40jkim%2Femulators&old=22447%40jkim%2Femulators

As long as you define LIBICONV_PLUG or replace <iconv.h> with
</usr/include/iconv.h> you're fine.  I would define LIBICONV_PLUG
only if ICONV_LIB is empty though so you always use libiconv_open
and libiconv_close etc. with libiconv.  iconv_open and iconv_close
work with libiconv too but they are also what base iconv uses so
there's a higher risk of trouble.