From owner-svn-src-head@freebsd.org Thu Dec 1 03:07:59 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC551C5E965; Thu, 1 Dec 2016 03:07:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AD39811ED; Thu, 1 Dec 2016 03:07:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x242.google.com with SMTP id 144so11054306pfv.0; Wed, 30 Nov 2016 19:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=TsaIeffNhhqXio7V8tGRMkWapp5FuF6Vj4f8Wx1SVl8=; b=sz7HJojE1bMbgpDNl2Ogp119tolaSppbeLWxsIJPMwlHy2YcBfSLYj6eygX94CNjNm dIFLXzUt+iaIeS8oAi/mv3t/4UK9szNwWi8L0Ao5DIJ79jiiPIBNHExc6Q9Egd+bpuxn WVhZPu1Eva3lTp2AZeFCuLamK/Jom7VJy0Y+VvEFqzxkRp1ObnEVxQ+MF2g+cY+YRJVH zTzijoNnuE8srsCAqSziEft+OemHPtFQC78aUNtS9pFOioTnlkXyakEFfcOt0laLwwEd X/BMlCcxuxU7BUhP+4K9RZb8gb25bEbYKwPIeyhMraz+xlhwkTe4WxL+SWLGp95dEvqa KYgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=TsaIeffNhhqXio7V8tGRMkWapp5FuF6Vj4f8Wx1SVl8=; b=HOP8qnt//MPHSXMFIMR8N7bENagFEE0eZ55PzdZUmLlS03euDb00FdpoCzeKHwaYlb FzxXX67Yjy48hjd0VDq8r4+CSjq6VQb1MlaVQFxCNfF5ts0IZp2fQqKcDw2a9xNKndo8 nEImZumGfP3VstDFZZ7JdthG8HZ2CacOIaMnCcAOe2liNMuqrYgE7t1E9WDE8he3B1a/ Dd/VrKXgN/5AgaJOmn5LCoAJIUftMP5P/A8vlFuSe2GTpTlwWbk3SbCcjkOjVXHPAwK8 kIw2g1KndOgUoUDAo9cIkDiAnkdOgcqErQoFtw8nOdVHH/w7FD5wP6cxm3bq8Q99CnWD 2OtA== X-Gm-Message-State: AKaTC03fNxp24DBy5Ver29/6a+VHOMdJ4BQCM67yhBs5SB+gwX3SURFQobnQdsbm2j0tPQ== X-Received: by 10.99.37.195 with SMTP id l186mr64510827pgl.91.1480561679135; Wed, 30 Nov 2016 19:07:59 -0800 (PST) Received: from ?IPv6:2607:fb90:80a6:d7d:3150:ed8c:ca08:27e4? ([2607:fb90:80a6:d7d:3150:ed8c:ca08:27e4]) by smtp.gmail.com with ESMTPSA id 72sm102541894pfw.37.2016.11.30.19.07.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2016 19:07:58 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r309344 - head/lib/libutil From: Ngie Cooper X-Mailer: iPhone Mail (14B100) In-Reply-To: <201612010221.uB12Lb6x067202@repo.freebsd.org> Date: Wed, 30 Nov 2016 19:07:57 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4DFE017D-90FD-44F4-8FE7-7EE53D499F7B@gmail.com> References: <201612010221.uB12Lb6x067202@repo.freebsd.org> To: "Conrad E. Meyer" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 03:08:00 -0000 > On Nov 30, 2016, at 18:21, Conrad E. Meyer wrote: >=20 > Author: cem > Date: Thu Dec 1 02:21:36 2016 > New Revision: 309344 > URL: https://svnweb.freebsd.org/changeset/base/309344 >=20 > Log: > Remove a death threat from the FreeBSD sources >=20 > Reported by: koobs@, araujo@, linimon@, bjk@, emaste@, jhb@, ngie@, ce= m@ > Maintainer timeout: des@ Really?? I wish you hadn't added me to this list.. I don't in any way endors= e the way that you went about dealing with this disagreement. You kind of ju= st pissed all over what des@ did out of spite. > Modified: > head/lib/libutil/flopen.c >=20 > Modified: head/lib/libutil/flopen.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/lib/libutil/flopen.c Thu Dec 1 01:56:34 2016 (r309343) > +++ head/lib/libutil/flopen.c Thu Dec 1 02:21:36 2016 (r309344) > @@ -40,10 +40,10 @@ __FBSDID("$FreeBSD$"); > /* > * Reliably open and lock a file. > * > - * DO NOT, UNDER PAIN OF DEATH, modify this code without first reading th= e > - * revision history and discussing your changes with . > - * Don't be fooled by the code's apparent simplicity; there would be no > - * need for this function if it was as easy to get right as you think. > + * Please do not modify this code without first reading the revision hist= ory > + * and discussing your changes with . Don't be fooled b= y the > + * code's apparent simplicity; there would be no need for this function i= f it > + * was easy to get right. > */ > int > flopen(const char *path, int flags, ...) > @@ -108,7 +108,11 @@ flopen(const char *path, int flags, ...) > errno =3D serrno; > return (-1); > } > -#ifdef DONT_EVEN_THINK_ABOUT_IT > + /* > + * The following change is provided as a specific example to > + * avoid. > + */ > +#if 0 > if (fcntl(fd, F_SETFD, FD_CLOEXEC) !=3D 0) { > serrno =3D errno; > (void)close(fd); >=20