Date: Fri, 4 Dec 1998 12:09:37 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet icmp_var.h Message-ID: <199812042009.MAA17142@apollo.backplane.com> References: <199812040349.TAA22636@freefall.freebsd.org> <19981204070811.A40154@nagual.pp.ru> <19981204071357.A41880@nagual.pp.ru> <199812040427.UAA03604@apollo.backplane.com> <19981204113427.A19232@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
: :On Thu, Dec 03, 1998 at 08:27:55PM -0800, Matthew Dillon wrote: :> Due to the extern badport_bandlim() I have to keep the #include in :> icmp_var.h ... but it isn't that bad, only three kernel files depend :> on icmp_var.h. I agree that doing the #include'ing in the two C files :> is cleaner, but what to do about the extern then ? : :Even in this variant you can safely remove opt_....h from icmp_var.h and :include it only into really affected *.c files instead (before :icmp_var.h). For kernel files which not needs this stuff but include :icmp_var.h even badport_...() prototype will be not picked which is good. : :-- :Andrey A. Chernov :http://www.nagual.pp.ru/~ache/ :MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y Ok, you mean keep the double #ifdef's at the end and the extern in the middle, but remove the opt #include and instead include the opt #include in the C files that require it prior to including icmp_var.h ?? That sounds reasonable. If I keep badport_bandlim() in ip_icmp.c, I definitely want to keep the extern either in icmp_var.h or in ip_icmp.h -Matt Matthew Dillon Engineering, HiWay Technologies, Inc. & BEST Internet Communications & God knows what else. <dillon@backplane.com> (Please include original email in any response) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812042009.MAA17142>