Date: Fri, 27 Nov 2009 17:34:19 -0500
From: Joe Marcus Clarke <marcus@FreeBSD.org>
To: Kostik Belousov <kostikbel@gmail.com>
Cc: "threads@freebsd.org" <threads@FreeBSD.org>
Subject: Re: [PATCH] Add missing pthread_condattr_{init,destroy} stubs to libc
Message-ID: <1259361259.1608.50.camel@shumai.marcuscom.com>
In-Reply-To: <20091127223042.GM2368@deviant.kiev.zoral.com.ua>
References: <1259298918.1608.19.camel@shumai.marcuscom.com> <20091127131242.GA2368@deviant.kiev.zoral.com.ua> <1259349248.1608.36.camel@shumai.marcuscom.com> <4AF1E295-0524-4C39-94CD-9A12D574C64D@vigrid.com> <20091127213046.GI2368@deviant.kiev.zoral.com.ua> <1259358800.1608.46.camel@shumai.marcuscom.com> <20091127220706.GJ2368@deviant.kiev.zoral.com.ua> <1259359873.1608.48.camel@shumai.marcuscom.com> <20091127222224.GL2368@deviant.kiev.zoral.com.ua> <1259360887.1608.49.camel@shumai.marcuscom.com> <20091127223042.GM2368@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-USrfwGfywnjScHQ2rIX0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2009-11-28 at 00:30 +0200, Kostik Belousov wrote: > On Fri, Nov 27, 2009 at 05:28:07PM -0500, Joe Marcus Clarke wrote: > > On Sat, 2009-11-28 at 00:22 +0200, Kostik Belousov wrote: > > > On Fri, Nov 27, 2009 at 05:11:13PM -0500, Joe Marcus Clarke wrote: > > > > I didn't see a better way of fixing this. I'm still fuzzy on how t= o do > > > > the correct symbol map dance for libthr/libc_r. Do you know of any > > > > example symbols which had to be updated in this fashion? > > >=20 > > > pthread_condattr_init and _destroy are exported from libthr in FBSD_1= .0. > > > namespace. I think stubs should go into FBSD_1.0 namespace in libc th= en. > > >=20 > > > We nullified one of the use for symver by extending existing > > > namespaces (symbol versioning, as defined by Sun, allowed for dynamic > > > linker to make a guarantee that process does not have unresolved > > > symbols only by checking that all required versions are provided > > > by libraries). My opinion that adding them to FBSD_1.0 is ok. > >=20 > > That's easy enough. New patch is up. > >=20 > > http://www.marcuscom.com/downloads/stubs.diff >=20 > I think symbols should be added in the pthread_* block of the > libc/gen/Symbol.map, arranged alphabetically. Wasn't sure of that. I had it that way originally, then I thought maybe they were being organized in order of inclusion (as I saw some others out of alphabetical order). I can easily shuffle them around. Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-USrfwGfywnjScHQ2rIX0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEABECAAYFAksQU+kACgkQb2iPiv4Uz4ePsACeKL8QFlrV3osUoBaooNKtf0oz sz4AoKp+/1YjGNyBpdytGB4XKsPRdiOA =5o2s -----END PGP SIGNATURE----- --=-USrfwGfywnjScHQ2rIX0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1259361259.1608.50.camel>