Date: Thu, 10 Nov 2005 01:02:50 +0300 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Maksim Yevmenkin <maksim.yevmenkin@savvis.net> Cc: Brooks Davis <brooks@one-eyed-alien.net>, freebsd-bluetooth@freebsd.org, freebsd-rc@freebsd.org Subject: Re: [RFC] rc.d integration for the bluetooth subsystem Message-ID: <20051109220250.GA91874@comp.chem.msu.su> In-Reply-To: <20051109191626.GG12837@odin.ac.hmc.edu> References: <436A6649.7000602@savvis.net> <20051103203217.GA30685@odin.ac.hmc.edu> <436BE02D.2020404@savvis.net> <20051107200040.GB29473@odin.ac.hmc.edu> <4370EAB4.8090000@savvis.net> <20051108201620.GD27091@odin.ac.hmc.edu> <43713B7D.7090405@savvis.net> <20051109063847.GB4605@comp.chem.msu.su> <43723223.3030802@savvis.net> <20051109191626.GG12837@odin.ac.hmc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 09, 2005 at 11:16:26AM -0800, Brooks Davis wrote:
> On Wed, Nov 09, 2005 at 09:30:11AM -0800, Maksim Yevmenkin wrote:
> > All,
> >
> > >>i also removed offending { } in while loop stdin redirection. if this is
> > >
> > >Thanks! The handling of {} seems to be one of gray corners in sh(1)
> > >syntax if it works as in the initial version of your script. Another
> > >one I've noticed is the case operator. Your line was like this:
> > >
> > > case $line in
> > >
> > >and it still worked for $line containing IFS chars. sh(1) seems
> > >to put double quotes aroung the word passed to case implicitly.
> > >While such things may seem to make sh(1) coding a tad easier, I'm
> > >afraid they shouldn't be relied upon.
> >
> > ok, do we agree that
> >
> > http://people.freebsd.org/~emax/bluetooth-rc-4.diff.txt
> >
> > looks fine? i have added double quotes around variables in case
> > statements. any other comments, suggestions, objections?
>
> Looks good to me.
To me, too (as good as it can look to a person who has never used
bluetooth :-) I think it should be a good beginning.
--
Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051109220250.GA91874>