Date: Wed, 3 May 2017 13:32:25 -0600 From: Alan Somers <asomers@freebsd.org> To: Ngie Cooper <yaneurabeya@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r317755 - head/sbin/ifconfig Message-ID: <CAOtMX2hbiXAna_UxMonf1Drqx3PkzW2%2BToezai%2BQ32VYq_DXSg@mail.gmail.com> In-Reply-To: <8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD@gmail.com> References: <201705031721.v43HL2vS071819@repo.freebsd.org> <8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 3, 2017 at 12:16 PM, Ngie Cooper <yaneurabeya@gmail.com> wrote: > >> On May 3, 2017, at 10:21, Alan Somers <asomers@FreeBSD.org> wrote: >> >> Author: asomers >> Date: Wed May 3 17:21:01 2017 >> New Revision: 317755 >> URL: https://svnweb.freebsd.org/changeset/base/317755 >> >> Log: >> Various Coverity fixes in ifconfig(8) > > ... > >> * Mark usage() as _Noreturn (1305806, 1305750) > > ... > >> -static void usage(void); >> +static void usage(void) _Noreturn; > > Hi Alan, > Please use __dead2 instead to be consistent with legacy use of similar gcc attributes. > Thanks, > -Ngie Why not use _Noreturn? It's standardized by C11, so tools understand it better than __dead2. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2hbiXAna_UxMonf1Drqx3PkzW2%2BToezai%2BQ32VYq_DXSg>