Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 01 Feb 2001 23:39:56 +0900
From:      FUJISHIMA Satsuki <sf@FreeBSD.org>
To:        ports@FreeBSD.org
Subject:   call for review: portlint
Message-ID:  <86zog6a2mb.wl@cheerful.com>

next in thread | raw e-mail | index | archive | help
Currently portlint points "unnecessary blank line at the last part"
warning for many files/patch-*, but this warning is unnecessary. Those
patches made with diff -u sometimes includes some '0x20\n' at the end
of file.

This patch is to ignore such a patch files. I'm going to commit this
in a few days if no one have object.

-- 
FUJISHIMA Satsuki

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/portlint/Makefile,v
retrieving revision 1.42
diff -u -r1.42 Makefile
--- Makefile	2000/12/12 14:24:12	1.42
+++ Makefile	2001/02/01 14:21:05
@@ -8,7 +8,7 @@
 #
 
 PORTNAME=	portlint
-PORTVERSION=	2.3
+PORTVERSION=	2.3.1
 CATEGORIES=	devel
 MASTER_SITES=	# none
 DISTFILES=	# none
Index: src/portlint.pl
===================================================================
RCS file: /home/ncvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.25
diff -u -r1.25 portlint.pl
--- src/portlint.pl	2000/12/31 18:59:43	1.25
+++ src/portlint.pl	2001/02/01 14:33:19
@@ -572,7 +572,7 @@
 		&perror("FATAL: the last line of $file has to be ".
 			"terminated by \\n.");
 	}
-	if ($whole =~ /\n([ \t]*\n)+$/) {
+	if ($whole =~ /\n([ \t]*\n)+$/ and $whole !~ /\n( \n)+$/) {
 		&perror("WARN: $file seems to have unnecessary blank lines ".
 			"at the last part.");
 	}


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86zog6a2mb.wl>