Date: Wed, 25 Jan 2017 19:55:14 -0800 From: Cy Schubert <Cy.Schubert@komquats.com> To: Bruce Evans <brde@optusnet.com.au> Cc: Cy Schubert <cy@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312780 - head/contrib/ipfilter/tools Message-ID: <201701260355.v0Q3tEhF092816@slippy.cwsent.com> In-Reply-To: Message from Bruce Evans <brde@optusnet.com.au> of "Thu, 26 Jan 2017 14:50:47 %2B1100." <20170126144726.U1265@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20170126144726.U1265@besplex.bde.org>, Bruce Evans writes: > On Wed, 25 Jan 2017, Cy Schubert wrote: > > > Log: > > Remove extraneous blank line. > > > > MFC after: 2 weeks > > X-MFC with: r312777 > > > > Modified: > > head/contrib/ipfilter/tools/ipf.c > > > > Modified: head/contrib/ipfilter/tools/ipf.c > > =========================================================================== > === > > --- head/contrib/ipfilter/tools/ipf.c Wed Jan 25 20:59:06 2017 > (r312779) > > +++ head/contrib/ipfilter/tools/ipf.c Wed Jan 25 20:59:23 2017 > (r312780) > > @@ -409,7 +409,6 @@ static void flushfilter(arg, filter) > > closedevice(); > > return; > > } > > - > > else if (strchr(arg, 'i') || strchr(arg, 'I')) > > fl = FR_INQUE; > > else if (strchr(arg, 'o') || strchr(arg, 'O')) > > Now it has 1 extra instead of 2 extra. > > Most code in ipfilter, and all in the old version of this file, uses the > normal KNF style of cuddling elses. I suppose I should compress it one more. I'll do that after the change window I'm working on tonight (if it's not too late and I'm not too tired). Thanks for your input Bruce. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701260355.v0Q3tEhF092816>