From owner-cvs-all Wed Feb 7 6:34:13 2001 Delivered-To: cvs-all@freebsd.org Received: from mobile.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147]) by hub.freebsd.org (Postfix) with ESMTP id 1068237B491; Wed, 7 Feb 2001 06:33:49 -0800 (PST) Received: from netplex.com.au (localhost [127.0.0.1]) by mobile.wemm.org (8.11.1/8.11.1) with ESMTP id f17EXmt64539; Wed, 7 Feb 2001 06:33:48 -0800 (PST) (envelope-from peter@netplex.com.au) Message-Id: <200102071433.f17EXmt64539@mobile.wemm.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Cameron Grant Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Broken PCM - Re: cvs commit: src/sys/dev/sound/pcm channel.c In-Reply-To: <200102070648.f176mTJ68070@freefall.freebsd.org> Date: Wed, 07 Feb 2001 06:33:48 -0800 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Cameron Grant wrote: > cg 2001/02/06 22:48:29 PST > > Modified files: > sys/dev/sound/pcm channel.c > Log: > conditionalize "hwptr went backwards" messages > > modify default buffer size heuristic to not max out at 4k. mpg123 should n ow > behave better under load. > > Revision Changes Path > 1.49 +430 -806 src/sys/dev/sound/pcm/channel.c I dont think you meant to commit all this stuff.. It breaks the kernel pretty badly. pcm_channel doesn't have the mutexes yet. Your MFC said "merge rev 1.49" which was a couple of lines at the most, so I think you accidently committed this stuff. I backed out the change locally and hand-applied the MFC'ed patches to rev 1.48 and it seems to work fine. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message