Date: Sun, 01 Mar 2015 20:39:30 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Jean-Sebastien Pedron <dumbbell@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r279487 - head/sys/dev/pci Message-ID: <vbik-1p8t-wny@FreeBSD.org> In-Reply-To: <201503011247.t21Clb2p035966@svn.freebsd.org> (Jean-Sebastien Pedron's message of "Sun, 1 Mar 2015 12:47:37 %2B0000 (UTC)") References: <201503011247.t21Clb2p035966@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Jean-Sebastien Pedron <dumbbell@FreeBSD.org> writes:
> Modified: head/sys/dev/pci/vga_pci.c
[...]
> +int
> +vga_pci_repost(device_t dev)
> +{
> +#if defined(__amd64__) || defined(__i386__)
> + x86regs_t regs;
> +
> + if (!vga_pci_is_boot_display(dev))
> + return (EINVAL);
> +
> + if (x86bios_get_orm(VGA_PCI_BIOS_SHADOW_ADDR) == NULL)
> + return (ENOTSUP);
> +
> + x86bios_init_regs(®s);
[...]
This breaks build for a kernel without VESA or X86BIOS. Also, x86bios
maybe loaded later as a module.
$ make buildkernel
--- kernel.debug ---
linking kernel.debug
vga_pci.o: In function `vga_pci_repost':
/usr/src/sys/dev/pci/vga_pci.c:208: undefined reference to `x86bios_get_orm'
/usr/src/sys/dev/pci/vga_pci.c:211: undefined reference to `x86bios_init_regs'
/usr/src/sys/dev/pci/vga_pci.c:218: undefined reference to `x86bios_call'
/usr/src/sys/dev/pci/vga_pci.c:221: undefined reference to `x86bios_get_intr'
*** [kernel.debug] Error code 1
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJU82ryXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b6UYH/0TN2yhOCM+PvgWf6Xhi2yYa
+JcEXTMum5UZnwrrXtJKLxg/joDlXb9Af+ESpwmg3wYP+Ku3YQ8C20+VSf627JEI
Zad4diaRFMO1wK2Tpcjq9lm3u96x1qQTe7z2yuKooGjX1yjT/B64CDwjteM2uraO
TJq5R7dvk1r9UiwXQNUgW8pmyN9yQwbcfUpxYK4FOVnYOjg29MTVk/qifJVz6fyo
oq1KsbiJNQMY5Q6sLZpo9+E+lSi+vjOvMZ3TBpwhStU/YOB+pQL39YhZQSpdMPv7
dzifISK5W6GboI1zHlCCFk3pxxfxfyD2af+xz3J9en+h4wJSOiRYYY3K+haoO5E=
=EZyo
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?vbik-1p8t-wny>