From owner-freebsd-emulation@FreeBSD.ORG  Fri Feb 21 19:13:38 2014
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: vbox@FreeBSD.org
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by hub.freebsd.org (Postfix) with ESMTP id 14157347;
 Fri, 21 Feb 2014 19:13:38 +0000 (UTC)
Message-ID: <5307A561.2000706@FreeBSD.org>
Date: Fri, 21 Feb 2014 14:13:37 -0500
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
To: Tijl Coosemans <tijl@FreeBSD.org>
Subject: Re: emulators/virtualbox-ose doesn't compile with libiconv
References: <20140210191712.728e1b7d@s100.slimaczek.pl>	<20140221170046.07c87bce@kalimero.tijl.coosemans.org>	<20140221174251.72fa8e74@kalimero.tijl.coosemans.org>	<530796B0.5040100@FreeBSD.org>
 <20140221194853.277adcb9@kalimero.tijl.coosemans.org>
In-Reply-To: <20140221194853.277adcb9@kalimero.tijl.coosemans.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Fri, 21 Feb 2014 19:49:53 +0000
Cc: vbox@FreeBSD.org
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Development of Emulators of other operating systems
 <freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation/>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Feb 2014 19:13:38 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2014-02-21 13:48:53 -0500, Tijl Coosemans wrote:
> On Fri, 21 Feb 2014 13:10:56 -0500 Jung-uk Kim wrote:
>> On 2014-02-21 11:42:51 -0500, Tijl Coosemans wrote:
>>> On Fri, 21 Feb 2014 17:00:46 +0100 Tijl Coosemans wrote:
>>>> On Mon, 10 Feb 2014 19:17:12 +0100 Tomasz Sowa wrote:
>>>>> emulators/virtualbox-ose doesn't compile when 
>>>>> converters/libiconv is installed:
>>>> 
>>>> Please try the attached patch for the port Makefile.
>>> 
>>> Sorry, that one was incomplete.  This one should work better.
>> 
>> Actually, I fixed it in my tree little differently.
>> 
>> https://redports.org/changeset?reponame=&new=23380%40jkim%2Femulators&old=22447%40jkim%2Femulators
>
>> 
> As long as you define LIBICONV_PLUG or replace <iconv.h> with 
> </usr/include/iconv.h> you're fine.  I would define LIBICONV_PLUG 
> only if ICONV_LIB is empty though so you always use libiconv_open 
> and libiconv_close etc. with libiconv.  iconv_open and iconv_close 
> work with libiconv too but they are also what base iconv uses so 
> there's a higher risk of trouble.

Done.

https://redports.org/changeset/23406/jkim

JK
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQEcBAEBAgAGBQJTB6VhAAoJEHyflib82/FGakIH/2Z3vCYttYaxeihULI79/kbh
YhchYLJWYQ09hKGhz5EdnCyDW4/HHn8zsplHpyCfIE7WtNxJl3nDBIJMKtsSuSXN
lIyKq7t8VTl7LCCfgvocvhGJqv3PxCk4yf7LMP8VvC3ewdyn8eLNHkc+UzFcqmaO
9fSlL1RAJGD+q84iOWoeGgYr6z2UXGfj7g7IKPdfF1uoBQJKt0UQJBOZZSyes+QV
QOUSwthTjQ4RNkOIoz3RjOKbqMeKCG763t/nXDxyF6GjnvVLF4HZMdU2LcJU5pCC
0mj/Qu6Iq3r/HoHGM6Ozu24GO/C6Sl0PbKCPqDbQEEjkhlLtPbxuwVnAMiWhVw4=
=DI7j
-----END PGP SIGNATURE-----