From owner-cvs-all Mon Nov 18 23: 6:17 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B85137B404 for ; Mon, 18 Nov 2002 23:06:16 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 4FE1643E8A for ; Mon, 18 Nov 2002 23:06:15 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 59609 invoked by uid 1000); 19 Nov 2002 07:06:17 -0000 Date: Mon, 18 Nov 2002 23:06:17 -0800 (PST) From: Nate Lawson To: Jake Burkholder Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: src/sys/dev/sab sab.c In-Reply-To: <20021117160343.6D41037B498@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > Modified files: > sys/dev/sab sab.c > Log: > - Add support for ALT_BREAK_TO_DEBUGGER; this is the only reliable way > to trigger a breakpoint with this chip. When I put together the GDB_AUTO_ENTER patch, I made a decision to abstract out the state machine. You pass it a char and it returns 1 if it has reached a match or zero otherwise. If multiple state machines were needed (say sio + sab) then the caller would pass in static storage for the state (say from the softc). Since you've duplicated the ALT_BREAK_TO_DEBUGGER state machine now, it should probably get moved into its own function as well. One question I had was where such state machines should go. Since they're dependent on DDB, I put mine in db_trap.c. Ideas? I think this is a useful move since there are UDP-based gdb stubs as well. -Nate (Patch at http://www.root.org/~nate/freebsd) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message