From owner-freebsd-net@freebsd.org Fri Sep 20 04:27:12 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B2D96F15B2 for ; Fri, 20 Sep 2019 04:27:12 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZLKC4l0Lz3C1Q for ; Fri, 20 Sep 2019 04:27:11 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd33.google.com with SMTP id q10so13213611iop.2 for ; Thu, 19 Sep 2019 21:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jpeJfp0wA+xEpxV3LB9DP0ExyEAYDhk/4FF4kZ2v3xY=; b=u7Gtct5A8iJFizRILdmdppNsLf5su6o7OzHQj8zgg0mB8q8N5SqT7TPhME9jnNmcNa P+fGV8+nAdTbgKo3Np2NJJqf5fUCqWbP/4WhLn1IrW2HleluM2DZi86NbXEXELN21SXO LBlSxeqtkjvXMyre7Dimf8BQvsdQZC0J3XEttnFWd89948lxNMHQK/RfuzEjV0+x2JOl nEn3ZyGU8ekGYzb6AwN7pYzl3wx0woqyQVbQUWGyPKj2Cz37OqArjIDLz/q3QZtXUUvn fIiEj1e2z9fTE30gCEs+9w0R3uT49bFK0M0ye1pvLLatrzcFkX+ndkodPBrz0G50iE1H cAeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jpeJfp0wA+xEpxV3LB9DP0ExyEAYDhk/4FF4kZ2v3xY=; b=p1Bz/xSYgAVNPtssKbVvNAsOrS4dxpkSeIIHUR4bJCLsAvY3REnLvdKtcNjDEiVgtD yHvvho9GfH/Y16ynP90Y+Ul/CA9CxBsdPu0VhwlVPBg0S7+t9PZzDOHX0Z0jlSXqsvHR R+KLA43HC+1N1TBW9wHpGzqL5EtJ24cMX9g3lIPaSh/Rv5BhW5emJHYUCiXypsyQmMhC +AaMlt7LdyQ3KPyuATGHrq9USS3qvLQbBIsGm4FuvYkd25I3vPbYzm6O4/LHxVxgVn/E rz6xKByFAUzsUPutruSrj3f5xb5lrW+PRXOM4pizTFfGy1ps3iiKQqQ5H+DOcGRtaLux m8yg== X-Gm-Message-State: APjAAAUIgVIb9H8oZ9EbsFo+g4CZQynzR8TwA9BifcmB9kXgoDCha58r oxDmb3+Aze0IwbfK+Ijr1mC3o4XZO71W3m1o/AU= X-Google-Smtp-Source: APXvYqz+Vo+Qpx8E4w2vlrpw1hTEgSh3Du1gAbW03wN2IPe/6H4/mr0LyHO8Qub0hMyiONp248kT3b+H0qdaw2sc9zU= X-Received: by 2002:a02:6616:: with SMTP id k22mr16440073jac.129.1568953629905; Thu, 19 Sep 2019 21:27:09 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> In-Reply-To: From: vm finance Date: Thu, 19 Sep 2019 21:26:59 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46ZLKC4l0Lz3C1Q X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=u7Gtct5A; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d33 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-4.19), ipnet: 2607:f8b0::/32(-2.66), asn: 15169(-2.21), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 04:27:12 -0000 finally ;) I was able to build it after manually extracting Makefile contents from patch. rebooting now ;) On Thu, Sep 19, 2019 at 8:12 PM Randall Stewart wrote: > There should have been some in the patch. Tomorrow I can send you a tar o= f > the modules/tcp/bbr Dir. > > It=E2=80=99s similar to the rack setup if you can=E2=80=99t wait and want= to be > adventurous > > R > > Sent from my iPhone > > On Sep 19, 2019, at 7:31 PM, vm finance wrote: > > Hi Randall, > > I already have tcp_bbr.h and bbr.c at ~sys/netinet/tcp_stacks/ > > However, there is no "bbr" under sys/modules/tcp/. I created this > directory manually. > Question: > Which Makefile do I need to copy/move under sys/modules/tcp/bbr? > I see there are Makefile and Makefile.org under ~modules/tcp... > > root@osboxes:/usr/src/sys/modules/tcp # ls -R > Makefile Makefile.orig bbr rack tcpmd5 > ./bbr: > > ./rack: > Makefile > > ./tcpmd5: > Makefile > > Please let me know. > > Thanks for your help! > > On Thu, Sep 19, 2019 at 11:05 AM Randall Stewart wrote: > >> Ahh.. Look in your directory. >> >> You did not create the sub=E2=80=99dirs or put rack.c or bbr.c into the = right >> places >> >> When you load the patch (which was updated Sept 17th and should be >> different slightly) >> you will end up dropping a Makefile and bbr.c and tcp_bbr.h into the >> local dir since >> for what every reason patch cannot figure out how to place it. >> >> You must move >> >> bbr.c/tcp_bbr.h to -> sys/netinet/tcp_stacks >> >> You must create >> >> sys/modules/tcp/bbr >> >> and >> >> place the make file under there (just like rack=E2=80=99s). >> >> Do that and I think you will finally have it.. not sure why patch is not >> able to >> put the new files in the right places :0 >> >> R >> >> > On Sep 19, 2019, at 10:42 AM, vm finance wrote= : >> > >> > Hello Randall, >> > >> > I just retried it with headvm config that you had shared but still see >> error while doing >> > "make cleandepend" >> > >> > Any pointers highly appreciated. >> > >> > Thanks >> > >> > root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend >> > [...snip...] >> > >> > =3D=3D=3D> sysvipc/sysvshm (obj) >> > >> /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/sy= svshm >> created for /usr/src/sys/modules/sysvipc/sysvshm >> > =3D=3D=3D> tcp (obj) >> > =3D=3D=3D> tcp/bbr (obj) >> > cd: /usr/src/sys/modules/tcp/bbr: No such file or directory >> > *** Error code 2 >> > >> > Stop. >> > make[2]: stopped in /usr/src/sys/modules/tcp >> > *** Error code 1 >> > >> > Stop. >> > make[1]: stopped in /usr/src/sys/modules >> > *** Error code 1 >> > >> > Stop. >> > make: stopped in /usr/src/sys/amd64/compile/headvm >> > root@osboxes:/usr/src/sys/amd64/compile/headvm # >> > >> > >> > On Wed, Sep 18, 2019 at 11:08 PM vm finance >> wrote: >> > Hi Randall, >> > >> > I applied the patch available at: >> > https://reviews.freebsd.org/D21582?id=3D62213 >> > NOTE: This raw patch seems to be exactly the same as the one I >> downloaded on Sep10...hope I'm not missing anything here... >> > >> > I clicked on "download raw diff" and saved it to bbr_patch.diff file o= n >> my local machine >> > Step 1: Apply PATCH: >> > cd /usr/src/sys >> > patch < bbr_patch.diff >> > Patch was applied successfully - no errors seen there. >> > >> > Step 2: Update kernel config: >> > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL >> > Added three options to MYKERNEL (per ur email - I have also attached >> the compile MYKERNEL file) >> > cd /usr/src/sys/amd64/compile/MYKERNEL >> > make cleandepend >> > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ >> > [pls find the attached log file for exact error] >> > >> > make depend >> > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" >> > >> > STEP 3: >> > cd /usr/src/ >> > make buildkernel KERNCONF=3DMYKERNEL >> > This also fails due to prior errors in Step 2. >> > >> > Please find MYKERNEL config file + error logs. >> > >> > Many many thanks for taking time to help me through this! >> > >> > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and that >> successfully finished. >> > >> > >> > >> > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart >> wrote: >> > You can look in the config I sent.. but here is what >> > I have added to enable BBR and Rack to be built >> > ***** >> > makeoptions WITH_EXTRA_TCP_STACKS=3D1 >> > options TCPHPTS >> > options RATELIMIT >> > ****** >> > >> > So you should >> > 1) Apply the current patch in phabricator >> > 2) edit your config and add the above three lines >> > 3) go to the src dir and type >> > make buildkernel KERNCONF=3Dmyconf >> > >> > That should build and get you a kernel that will include bbr and rack. >> You will >> > need to, after it boots up type >> > >> > kldload tcp_bbr >> > >> > or >> > >> > kldload tcp_rack >> > >> > To get the modules loaded >> > >> > R >> > >> > >> > >> > > On Sep 18, 2019, at 2:31 PM, vm finance >> wrote: >> > > >> > > Hi Randall, Michael, >> > > >> > > Build is done successfully. I would appreciate if you could share >> config changes needed for BBR. >> > > >> > > My svn revision is: 352483 >> > > >> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >> > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | >> xargs -J% objcopy % zlib.ko.full >> > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug >> > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug zlib.ko.f= ull >> zlib.ko >> > > -------------------------------------------------------------- >> > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC 20= 19 >> > > -------------------------------------------------------------- >> > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 >> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >> > > >> > > Thank you >> > > Vishal. >> > > >> > > >> > > On Wed, Sep 18, 2019 at 3:34 PM vm finance >> wrote: >> > > I'm using amd64. I'd get back as soon as base build is complete. >> > > >> > > Thanks! >> > > >> > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart >> wrote: >> > > To get bbr running you will need to change your kernel config. >> > > >> > > Are you building i386 or amd64? >> > > >> > > After you have successfully did >> > > >> > > 1) buildworld >> > > 2) buildkernel >> > > 3) installkernel >> > > >> > > (you can look in UPDATING for instructions .. though the file is lon= g >> :D) >> > > >> > > successfully let me know.. and then I will give you the tweaks you >> need to add >> > > to the kerneconf. >> > > >> > > It won=E2=80=99t take as long to build because at that point you can= add in >> the >> > > NO_CLEAN NO_CLEANDIR options as well since you will have built >> everything >> > > the first time >> > > >> > > R >> > > >> > > > On Sep 18, 2019, at 7:06 AM, vm finance >> wrote: >> > > > >> > > > BTW, if you think I should be making any changes in configs, pleas= e >> do let me know. >> > > > My goal is to build a freebsd image with BBR patches on x86 VM. >> > > > Nothing fancy. >> > > > >> > > > thanks! >> > > > >> > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance >> wrote: >> > > > Thanks Randall, Michael, >> > > > >> > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" >> > > > and now doing "make buildworld buildkernel" >> > > > [I didn't change anything in configs - just whatever are the >> defaults] >> > > > >> > > > I would update as soon as its done. >> > > > >> > > > Thanks again! >> > > > >> > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart >> wrote: >> > > > One other note.. I notice his kernel conf he sent does not have >> > > > the right things to get BBR even to attempt to build. >> > > > >> > > > I would suggest using that config for the first steps.. then he >> must add >> > > > the additional tcp stacks and the hpts in order to get bbr/rack an= d >> any other >> > > > extra stack=E2=80=A6. >> > > > >> > > > But I would suggest to build with his current config first and onc= e >> he has >> > > > that in place and building >> > > > >> > > > a) apply the patch >> > > > b) add the extra kernel options >> > > > >> > > > R >> > > > >> > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart >> wrote: >> > > > > >> > > > > Thats great idea Michael. >> > > > > >> > > > > From the look fo the build log I was sent, his blow-up has >> nothing to do >> > > > > with the patches. >> > > > > >> > > > > He should probably >> > > > > >> > > > > 1) Check out a fresh version of head. >> > > > > 2) Follow the instructions in UPDATING to get a clean build. >> > > > > =E2=80=94 make buildworld >> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf >> > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf >> > > > > >> > > > > ** do the reboot and merge master ** >> > > > > >> > > > > Then after that he could >> > > > > >> > > > > 3) Apply the current patch in the review >> > > > > 4) do build that >> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN >> -DNO_CLEANDIR >> > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf >> > > > > >> > > > > And he should have it all working :) >> > > > > >> > > > > I have done multiple builds with the latest head from yesterday >> both with and without >> > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build fail= ure.. >> this would verify he can >> > > > > at least build head.. >> > > > > >> > > > > R >> > > > > >> > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < >> michael.tuexen@lurchi.franken.de> wrote: >> > > > >> >> > > > >>> On 18. Sep 2019, at 08:19, vm finance >> wrote: >> > > > >>> >> > > > >>> correcting a typo: >> > > > >>> >> > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src >> > > > >>> current revision: 352434 >> > > > >> I suggest to build/install head first without any patches. Afte= r >> that has worked, >> > > > >> apply the patches you are interested in. That way it is easy to >> separate generic >> > > > >> build issues and issue specific to a patch. >> > > > >> >> > > > >> Best regards >> > > > >> Michael >> > > > >>> >> > > > >>> Thank you! >> > > > >>> >> > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>> >> > > > >>>> Actually I am on head already as mentioned previously. Pulled >> it using >> > > > >>>> yesterday: >> > > > >>>> >> > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src >> > > > >>>> >> > > > >>>> >> > > > >>>> If you could pls let me know the new patch, I can try that. >> > > > >>>> >> > > > >>>> Thanks >> > > > >>>> >> > > > >>>> Sent from my iPhone >> > > > >>>> >> > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart >> wrote: >> > > > >>>> >> > > > >>>> There have been several patches pre-this one that provide >> > > > >>>> the infrastructure to support BBR. >> > > > >>>> >> > > > >>>> Release 12.0 will *not* have these patches and will *not* >> compile it. >> > > > >>>> >> > > > >>>> I have no intention at this point in doing a MFC of this >> work.. so if you >> > > > >>>> want >> > > > >>>> to run BBR you need to run Head >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Hi Randall, >> > > > >>>> >> > > > >>>> >> > > > >>>> Could you please provide a pointer to the latest patch. I had >> applied the >> > > > >>>> one you published Sep-10. >> > > > >>>> >> > > > >>>> >> > > > >>>> Following is what I have done: >> > > > >>>> >> > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >> > > > >>>> >> > > > >>>> 2. Got VM up under VMPlayer on x86 laptop >> > > > >>>> >> > > > >>>> 3. Checked out latest codebase from freebsd repo: >> > > > >>>> >> > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* >> > > > >>>> >> > > > >>>> cd /usr/src; >> > > > >>>> >> > > > >>>> make buildworld buildkernel >> > > > >>>> >> > > > >>>> [this is where make fails when patch is applied] >> > > > >>>> >> > > > >>>> >> > > > >>>> I could try to build with your latest patch - please send me = a >> pointer. >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks for your help! >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart < >> rrs@netflix.com> wrote: >> > > > >>>> >> > > > >>>> Looking at your make file log I can=E2=80=99t really tell wha= t you are >> doing. >> > > > >>>> >> > > > >>>> >> > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >> > > > >>>> >> > > > >>>> >> > > > >>>> Are you cross compiling? >> > > > >>>> >> > > > >>>> >> > > > >>>> I have done the old fashioned kernel make >> > > > >>>> >> > > > >>>> >> > > > >>>> i.e. >> > > > >>>> >> > > > >>>> >> > > > >>>> cd src/sys/amd64/config >> > > > >>>> >> > > > >>>> config headvm >> > > > >>>> >> > > > >>>> cd ../compile/headvm >> > > > >>>> >> > > > >>>> >> > > > >>>> make cleandepend ; make depend; make -j3 >> > > > >>>> >> > > > >>>> >> > > > >>>> I have done >> > > > >>>> >> > > > >>>> >> > > > >>>> cd src >> > > > >>>> >> > > > >>>> make buildkernel KERNCONF=3Dheadvm >> > > > >>>> >> > > > >>>> >> > > > >>>> And even >> > > > >>>> >> > > > >>>> >> > > > >>>> make buildkernel KERNCONF=3DGENERIC >> > > > >>>> >> > > > >>>> >> > > > >>>> to make sure that the build works without bbr. >> > > > >>>> >> > > > >>>> >> > > > >>>> I attach my headvm config.. >> > > > >>>> >> > > > >>>> >> > > > >>>> What exactly are you building and how? kernel config too >> please? >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> looking >> > > > >>>> >> > > > >>>> >> > > > >>>> I was at 352408.. let me update and try it >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Hmm >> > > > >>>> >> > > > >>>> >> > > > >>>> Did you get the patch I updated too this am? >> > > > >>>> >> > > > >>>> >> > > > >>>> I have built it both with and without the bbr stack and had n= o >> issue.. >> > > > >>>> there was >> > > > >>>> >> > > > >>>> an issue with KTLS before the update though. >> > > > >>>> >> > > > >>>> >> > > > >>>> I don=E2=80=99t recognize what you have below there though=E2= =80=A6 >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Got it - thank you! >> > > > >>>> >> > > > >>>> >> > > > >>>> btw, I tried to build the patch but its giving an error. >> Following is SVN >> > > > >>>> info + make error mesg. >> > > > >>>> >> > > > >>>> >> > > > >>>> Please let me know what am I missing here? >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks! >> > > > >>>> >> > > > >>>> >> > > > >>>> #svnlite revision >> > > > >>>> >> > > > >>>> Path: . >> > > > >>>> >> > > > >>>> Working Copy Root Path: /usr/src >> > > > >>>> >> > > > >>>> URL: svn://svn.freebsd.org/base/head >> > > > >>>> >> > > > >>>> Relative URL: ^/head >> > > > >>>> >> > > > >>>> Repository Root: svn://svn.freebsd.org/base >> > > > >>>> >> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > > > >>>> >> > > > >>>> Revision: 352436 >> > > > >>>> >> > > > >>>> Node Kind: directory >> > > > >>>> >> > > > >>>> Schedule: normal >> > > > >>>> >> > > > >>>> Last Changed Author: jah >> > > > >>>> >> > > > >>>> Last Changed Rev: 352434 >> > > > >>>> >> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 201= 9) >> > > > >>>> >> > > > >>>> >> > > > >>>> root@osboxes:/usr/src # >> > > > >>>> >> > > > >>>> >> > > > >>>> -------------------------------------------- snip >> > > > >>>> ---------------------------- >> > > > >>>> >> > > > >>>> >> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > > > >>>> >> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > > > >>>> >> > > > >>>> =3D=3D=3D> sys (cleandir) >> > > > >>>> >> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h >> > > > >>>> opt_kern_tls.h >> > > > >>>> >> > > > >>>> rm: x86: is a directory >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[3]: stopped in /usr/src/sys >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[2]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[1]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make: stopped in /usr/src >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>>> >> > > > >>>> Got it - thank you! >> > > > >>>> >> > > > >>>> >> > > > >>>> btw, I tried to build the patch but its giving an error. >> Following is SVN >> > > > >>>> info + make error mesg. >> > > > >>>> >> > > > >>>> I have also attached the entire build log...snippet is below >> > > > >>>> >> > > > >>>> >> > > > >>>> Please let me know what am I missing here? >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks! >> > > > >>>> >> > > > >>>> >> > > > >>>> #svnlite revision >> > > > >>>> >> > > > >>>> Path: . >> > > > >>>> >> > > > >>>> Working Copy Root Path: /usr/src >> > > > >>>> >> > > > >>>> URL: svn://svn.freebsd.org/base/head >> > > > >>>> >> > > > >>>> Relative URL: ^/head >> > > > >>>> >> > > > >>>> Repository Root: svn://svn.freebsd.org/base >> > > > >>>> >> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > > > >>>> >> > > > >>>> Revision: 352436 >> > > > >>>> >> > > > >>>> Node Kind: directory >> > > > >>>> >> > > > >>>> Schedule: normal >> > > > >>>> >> > > > >>>> Last Changed Author: jah >> > > > >>>> >> > > > >>>> Last Changed Rev: 352434 >> > > > >>>> >> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 201= 9) >> > > > >>>> >> > > > >>>> >> > > > >>>> root@osboxes:/usr/src # >> > > > >>>> >> > > > >>>> >> > > > >>>> -------------------------------------------- snip >> > > > >>>> ---------------------------- >> > > > >>>> >> > > > >>>> >> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > > > >>>> >> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > > > >>>> >> > > > >>>> =3D=3D=3D> sys (cleandir) >> > > > >>>> >> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h >> > > > >>>> opt_kern_tls.h >> > > > >>>> >> > > > >>>> rm: x86: is a directory >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[3]: stopped in /usr/src/sys >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[2]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[1]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make: stopped in /usr/src >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart < >> rrs@netflix.com> wrote: >> > > > >>>> >> > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches d= o >> not have >> > > > >>>> >> > > > >>>> to have fq.. they built an alternate means of doing pacing >> into bbr. >> > > > >>>> >> > > > >>>> >> > > > >>>> In either case our testing has shown that our pacing is more >> accurate than >> > > > >>>> >> > > > >>>> either fq or the internal pacer :) >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks Randall. >> > > > >>>> >> > > > >>>> I was able to apply the patch - now rebuilding the kernel. >> Would update on >> > > > >>>> how it goes. >> > > > >>>> >> > > > >>>> >> > > > >>>> BTW, is there any description on how lack of tc_fq under >> FreeBSD is >> > > > >>>> compensated here? >> > > > >>>> >> > > > >>>> The original BBR patches on Linux show that as a must-have? I= s >> that >> > > > >>>> functionality implemented via tcp_ratelimit.[ch]? >> > > > >>>> >> > > > >>>> >> > > > >>>> Any pointers to existing presentations/discussions highly >> appreciated? >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks a lot. >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart < >> rrs@netflix.com> wrote: >> > > > >>>> >> > > > >>>> You should be able to compile it against the current head. I >> re-doing that >> > > > >>>> now (had an >> > > > >>>> >> > > > >>>> issue with my machine and had to roll it back to a backup). >> > > > >>>> >> > > > >>>> >> > > > >>>> When I put the patch up on Sept 10th it complied with and >> without BBR on >> > > > >>>> whatever >> > > > >>>> >> > > > >>>> was that rev.. >> > > > >>>> >> > > > >>>> >> > > > >>>> Looking in the commit logs that would have been around 352191 >> > > > >>>> >> > > > >>>> >> > > > >>>> Hope that helps >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Hi Randall, >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks for releasing BBR patch: >> > > > >>>> >> > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >> > > > >>>> >> > > > >>>> >> > > > >>>> Could you please let me know what SVN/GIT label tag this is >> based on? I >> > > > >>>> would like to patch and experiment with it. I couldn't find >> this info in >> > > > >>>> the released patch. >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks a lot! >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone >> wrote: >> > > > >>>> >> > > > >>>> rrs@ has just posted the BBR patch to phabricator: >> > > > >>>> >> > > > >>>> >> > > > >>>> https://reviews.freebsd.org/D21582 >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> Randall Stewart >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>> _______________________________________________ >> > > > >>> freebsd-net@freebsd.org mailing list >> > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> > > > >>> To unsubscribe, send any mail to " >> freebsd-net-unsubscribe@freebsd.org" >> > > > > >> > > > > ------ >> > > > > Randall Stewart >> > > > > rrs@netflix.com >> > > > > >> > > > > >> > > > > >> > > > >> > > > ------ >> > > > Randall Stewart >> > > > rrs@netflix.com >> > > > >> > > > >> > > > >> > > >> > > ------ >> > > Randall Stewart >> > > rrs@netflix.com >> > > >> > > >> > > >> > >> > ------ >> > Randall Stewart >> > rrs@netflix.com >> > >> > >> > >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> >>