From owner-svn-src-all@freebsd.org Wed Jan 15 01:34:05 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AED111FB38E; Wed, 15 Jan 2020 01:34:05 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47y8xT4Bg5z3P7x; Wed, 15 Jan 2020 01:34:05 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8B30726CAD; Wed, 15 Jan 2020 01:34:05 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 00F1Y5Jh049381; Wed, 15 Jan 2020 01:34:05 GMT (envelope-from mjg@FreeBSD.org) Received: (from mjg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 00F1Y5t5049380; Wed, 15 Jan 2020 01:34:05 GMT (envelope-from mjg@FreeBSD.org) Message-Id: <202001150134.00F1Y5t5049380@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mjg set sender to mjg@FreeBSD.org using -f From: Mateusz Guzik Date: Wed, 15 Jan 2020 01:34:05 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r356745 - head/sys/kern X-SVN-Group: head X-SVN-Commit-Author: mjg X-SVN-Commit-Paths: head/sys/kern X-SVN-Commit-Revision: 356745 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2020 01:34:05 -0000 Author: mjg Date: Wed Jan 15 01:34:05 2020 New Revision: 356745 URL: https://svnweb.freebsd.org/changeset/base/356745 Log: vfs: in vop_stdadd_writecount only vlazy vnodes on mounts using msync The only reason to vlazy there is to (overzealously) ensure all vnodes which need to be visited by msync scan can be found there. In particluar this is of no use zfs and tmpfs. While here depessimize the check. Modified: head/sys/kern/vfs_default.c Modified: head/sys/kern/vfs_default.c ============================================================================== --- head/sys/kern/vfs_default.c Wed Jan 15 01:32:11 2020 (r356744) +++ head/sys/kern/vfs_default.c Wed Jan 15 01:34:05 2020 (r356745) @@ -1220,6 +1220,7 @@ static int vop_stdadd_writecount(struct vop_add_writecount_args *ap) { struct vnode *vp; + struct mount *mp; int error; vp = ap->a_vp; @@ -1229,9 +1230,12 @@ vop_stdadd_writecount(struct vop_add_writecount_args * } else { VNASSERT(vp->v_writecount + ap->a_inc >= 0, vp, ("neg writecount increment %d", ap->a_inc)); + if (vp->v_writecount == 0) { + mp = vp->v_mount; + if (mp != NULL && (mp->mnt_kern_flag & MNTK_NOMSYNC) == 0) + vlazy(vp); + } vp->v_writecount += ap->a_inc; - if (vp->v_writecount > 0 && vp->v_mount != NULL) - vlazy(vp); error = 0; } VI_UNLOCK(vp);