Date: Tue, 19 Mar 2002 15:14:11 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Warner Losh <imp@harmony.village.org> Cc: <obrien@FreeBSD.org>, Kirk McKusick <mckusick@mckusick.com>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/coda coda_vnops.c src/sys/dev/ccd ccd.c src/sys/dev/md md.c src/sys/dev/vinum vinumdaemon.c vinuminterrupt.c vinumrequest.c vinumrevive.c src/sys/fs/hpfs hpfs_vnops.c src/sys/f Message-ID: <20020319150911.H4131-100000@gamplex.bde.org> In-Reply-To: <200203182239.g2IMdGL96585@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 18 Mar 2002, Warner Losh wrote: > In message <20020318134628.A15033@dragon.nuxi.com> "David O'Brien" writes: > : On Fri, Mar 15, 2002 at 10:49:47AM -0800, Kirk McKusick wrote: > : > mckusick 2002/03/15 10:49:47 PST > : ... > : > Log: > : > Introduce the new 64-bit size disk block, daddr64_t. Change > : > the bio and buffer structures to have daddr64_t bio_pblkno, > : > b_blkno, and b_lblkno fields which allows access to disks > : > : Objects of type daddr64_t need to be cast to `(long long)' before > : printing them out with %lld. Failure to do so adds build warnings on > : 64-bit hosts. > > And on non-64-bit hosts. On some non-64-bit hosts, but not on i386's. daddr_t happens to have type long long on i386's. Failure to convert %u to %lld was fatal on on i386's in amr.c and mlx.c. %u was already doubly wrong: it assmed that daddr_t is u_int, but daddr_t is actually (signed) int32_t. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020319150911.H4131-100000>