Date: Wed, 15 Jun 2011 09:56:30 +0900 From: Takefu <takefu@airport.fm> To: Andrej Zverev <az@freebsd.org> Cc: Frederic Culot <culot@freebsd.org>, ports-committers@freebsd.org, cvs-all@freebsd.org, cvs-ports@freebsd.org Subject: Re: cvs commit: ports/www/p5-HTML-Defaultify Makefile Message-ID: <4DF8033E.7020003@airport.fm> In-Reply-To: <BANLkTi=RF%2B6-YZkH-aofCCqgshNFKdvx-w@mail.gmail.com> References: <201106141516.p5EFGaGY095553@repoman.freebsd.org> <BANLkTi=RF%2B6-YZkH-aofCCqgshNFKdvx-w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi. 2)a) It agrees with this change. Other reviews listed above is not a negative. Not too positive. Andrej Zverev さんは書きました (2011/06/15 1:44): > Hello. > I would like to suggest following patch. > 1) More preferable to depend on CPAN infrastructure less on private author > sites. > 2) Fix pkg-descr: > a) Description text from module > b) WWW: to CPAN (we prefer this I hope and it contrain full module > documentaion). > 3) Some Makefile rearrangement. > > Patch: http://sunner.semmy.ru/~az/patches/p5-HTML-Defaultify.diff.txt --- p5-HTML-Defaultify.patch begins here --- diff -ruN /usr/ports/www/p5-HTML-Defaultify/Makefile www/p5-HTML-Defaultify/Makefile --- /usr/ports/www/p5-HTML-Defaultify/Makefile 2011-06-15 09:18:52.000000000 +0900 +++ www/p5-HTML-Defaultify/Makefile 2011-06-15 09:23:36.000000000 +0900 @@ -15,12 +15,9 @@ MAINTAINER= takefu@airport.fm COMMENT= Perl module to populate HTML forms with default values -PERL_CONFIGURE= yes +RUN_DEPENDS= p5-HTML-Parser>=0:${PORTSDIR}/www/p5-HTML-Parser +PERL_CONFIGURE= yes MAN3= HTML::Defaultify.3 -.include <bsd.port.pre.mk> - -RUN_DEPENDS+= p5-HTML-Parser>=0:${PORTSDIR}/www/p5-HTML-Parser - -.include <bsd.port.post.mk> +.include <bsd.port.mk> diff -ruN /usr/ports/www/p5-HTML-Defaultify/pkg-descr www/p5-HTML-Defaultify/pkg-descr --- /usr/ports/www/p5-HTML-Defaultify/pkg-descr 2011-03-04 22:58:35.000000000 +0900 +++ www/p5-HTML-Defaultify/pkg-descr 2011-06-15 09:48:10.000000000 +0900 @@ -1,3 +1,10 @@ -HTML::Defaultify - Pre-fill default values into an existing HTML form +This module lets you take an existing HTML page with forms in it, and fill in +the form fields according to defaults you give. It's most useful in CGI +scripts. One common use is to handle invalid user input-- show them the same +form with their previously entered values filled in, and let them correct any +errors. Another use might be when letting users edit a database record, such as +their account information-- show them an input form with the current values +filled in. There are other uses. WWW: http://www.jmarshall.com/tools/defaultify/ + http://search.cpan.org/dist/HTML-Defaultify/ --- p5-HTML-Defaultify.patch ends here ---
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DF8033E.7020003>