From owner-cvs-all@FreeBSD.ORG Sun Jul 24 06:39:37 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92DA616A41F; Sun, 24 Jul 2005 06:39:37 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd4mo3so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3102143D46; Sun, 24 Jul 2005 06:39:37 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd4mr8so.prod.shaw.ca (pd4mr8so-qfe3.prod.shaw.ca [10.0.141.101]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IK4001GSD608YB0@l-daemon>; Sun, 24 Jul 2005 00:39:36 -0600 (MDT) Received: from pn2ml1so.prod.shaw.ca ([10.0.121.145]) by pd4mr8so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IK400FMWD606RC0@pd4mr8so.prod.shaw.ca>; Sun, 24 Jul 2005 00:39:36 -0600 (MDT) Received: from [192.168.0.60] (S0106006067227a4a.vc.shawcable.net [24.87.209.6]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.18 (built Jul 28 2003)) with ESMTP id <0IK40021DD5YHB@l-daemon>; Sun, 24 Jul 2005 00:39:36 -0600 (MDT) Date: Sat, 23 Jul 2005 23:39:34 -0700 From: Colin Percival In-reply-to: <200507231824.j6NIOl6v034122@repoman.freebsd.org> To: "Andrey A. Chernov" Message-id: <42E337A6.8060206@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Accept-Language: en-us, en References: <200507231824.j6NIOl6v034122@repoman.freebsd.org> User-Agent: Mozilla Thunderbird 1.0.5 (X11/20050714) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/games/fortune/fortune fortune.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jul 2005 06:39:37 -0000 Andrey A. Chernov wrote: > FreeBSD src repository > > Modified files: > games/fortune/fortune fortune.c > Log: > My change, namely srandomdev() addition, was backed out even without > discussing with me, and I obviously disagree seeing that afterwards > (srandomdev() back out not fix any thing, it can only mask the problem). > > So, back out the back out and return srandomdev(). Approved by: security-officer (cperciva) Any change which helps to make a security problem obvious is a good thing, and a commit which (like revision 1.28) simply hides a security problem from users is Not Desired. Colin Percival