Date: Fri, 22 Sep 2006 13:42:26 +0400 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Dirk Meyer <dirk.meyer@dinoex.sub.org> Cc: freebsd-ports@freebsd.org Subject: Re: A section on gettext for the Porter's Handbook Message-ID: <20060922094226.GC57184@comp.chem.msu.su> In-Reply-To: <ByX7fGX3bZ@dmeyer.dinoex.sub.org> References: <20060821071036.GA44406@comp.chem.msu.su> <20060821071036.GA44406@comp.chem.msu.su> <44ECBDC0.7000802@FreeBSD.org> <ByX7fGX3bZ@dmeyer.dinoex.sub.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 22, 2006 at 06:52:45AM +0200, Dirk Meyer wrote:
>
> > +.if defined(WITHOUT_NLS)
> > +CONFIGURE_ARGS+= --disable-nls
> > +PLIST_SUB+= NLS="@comment "
> > +.else
> > +USE_GETTEXT= yes
> > +CONFIGURE_ENV= LDFLAGS="-L${LOCALBASE}/lib"
> > +PLIST_SUB+= NLS=""
> > +.endif</programlisting>
>
> Please .. this will break ports which have LDFLAGS= set,
> eg. openssl or database ports.
> To preserve LDFLAGS, the example should be:
>
> -CONFIGURE_ENV= LDFLAGS="-L${LOCALBASE}/lib"
> +LDFLAGS+= -L${LOCALBASE}/lib
> +CONFIGURE_ENV+= LDFLAGS="${LDFLAGS}"
This is a very good point! Thanks! I've modified the current
version of the paragraph accordingly.
--
Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060922094226.GC57184>