Date: Tue, 14 Jan 2003 07:30:04 -0800 (PST) From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx> To: freebsd-ports@FreeBSD.org Subject: Re: ports/47039: [BENTO FIX] devel/cxref Message-ID: <200301141530.h0EFU4Mu039319@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/47039; it has been noted by GNATS.
From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Chris Knight <chris@aims.com.au>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47039: [BENTO FIX] devel/cxref
Date: Tue, 14 Jan 2003 16:28:27 +0100
--=.lsQU,mROR)EqLe
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Lately Chris Knight told:
> >Description:
> cxref self-references itself during the build of the doc subdirectory.
> On bento, this results in a core dump of cxref.
> However, none of the doc target gets installed.
> So, the easiest fix is to not build the doc target.
this is the completely wrong approach. don't ignore the problem, fix it:
new file: files/patch-af; bump portrevision (i'd vote for it)?
Index: files/patch-af
===================================================================
RCS file: files/patch-af
diff -N files/patch-af
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ files/patch-af 14 Jan 2003 15:23:10 -0000
@@ -0,0 +1,16 @@
+--- comment.c.orig Tue Nov 16 20:11:38 1999
++++ comment.c Tue Jan 14 16:17:17 2003
+@@ -158,8 +158,11 @@
+
+ if(comment)
+ {
+- malloc_comment=Realloc(malloc_comment,strlen(comment)+1);
+- strcpy(malloc_comment,comment);
++ if(malloc_comment != comment)
++ {
++ malloc_comment=Realloc(malloc_comment,strlen(comment)+1);
++ strcpy(malloc_comment,comment);
++ }
+ current_comment=malloc_comment;
+ }
+ else
dunno why this was never noticed; mebe because of special malloc()
behavior on tested platforms.
cheers
simon
--
/"\ http://corecode.ath.cx/#donate
\ /
\ ASCII Ribbon Campaign
/ \ Against HTML Mail and News
--=.lsQU,mROR)EqLe
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+JCyer5S+dk6z85oRAidmAKCOcorYMzkLHZtRimOFchveRDqV6wCg88q+
QVDnpRGF3skVvOZ4weYP9gQ=
=tTqy
-----END PGP SIGNATURE-----
--=.lsQU,mROR)EqLe--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301141530.h0EFU4Mu039319>