Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 May 2004 10:15:51 +0200
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        David Malone <dwmalone@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sbin/kldstat kldstat.c
Message-ID:  <20040530081550.GC12007@darkness.comp.waw.pl>
In-Reply-To: <200405282116.i4SLGin4067490@repoman.freebsd.org>
References:  <200405282116.i4SLGin4067490@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--6Nae48J/T25AfBN4
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 28, 2004 at 02:16:44PM -0700, David Malone wrote:
+> dwmalone    2004/05/28 14:16:44 PDT
+>=20
+>   FreeBSD src repository
+>=20
+>   Modified files:
+>     sbin/kldstat         kldstat.c=20
+>   Log:
+>   Decide how much space we need to print a pointer using
+>   sizeof(void *) rather than if __alpha__ is defined.
[...]
+> -#if defined(__alpha__)
+> -#define	POINTER_WIDTH	18
+> -#else
+> -#define	POINTER_WIDTH	10
+> -#endif
+> +#define	POINTER_WIDTH	(sizeof(void *) > 4 ? 18 : 10)

Why not just:

#define	POINTER_WIDTH	(sizeof(void *) * 2 + 2)

?

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--6Nae48J/T25AfBN4
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAuZg2ForvXbEpPzQRAmPHAKCYLNXpr+IHVTq98oHklfE0F6313gCgiQSA
FqJITc2lbCr7vJhcUEVpIM0=
=Elaj
-----END PGP SIGNATURE-----

--6Nae48J/T25AfBN4--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040530081550.GC12007>