From owner-cvs-all Thu Oct 1 14:49:46 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id OAA11242 for cvs-all-outgoing; Thu, 1 Oct 1998 14:49:46 -0700 (PDT) (envelope-from owner-cvs-all) Received: from cimlogic.com.au (cimlog.lnk.telstra.net [139.130.51.31]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA11199; Thu, 1 Oct 1998 14:49:28 -0700 (PDT) (envelope-from jb@cimlogic.com.au) Received: (from jb@localhost) by cimlogic.com.au (8.9.1/8.9.1) id HAA10815; Fri, 2 Oct 1998 07:57:16 +1000 (EST) (envelope-from jb) From: John Birrell Message-Id: <199810012157.HAA10815@cimlogic.com.au> Subject: Re: cvs commit: src/lib/libc_r/uthread uthread_gc.c Makefile.inc uthread_init.c uthread_find_thread.c uthread_kern.c uthread_cre In-Reply-To: <19981001092101.B7057@mcs.net> from Alex Nash at "Oct 1, 98 09:21:01 am" To: nash@mcs.net (Alex Nash) Date: Fri, 2 Oct 1998 07:57:15 +1000 (EST) Cc: jb@cimlogic.com.au, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL40 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Alex Nash wrote: > I wish this predictable behavior were true. The spinlock code allows > recursive locking by the same thread (libc_r/uthread/uthread_spinlock.c): [...] > /* Check if already locked by the running thread: */ > if (lck->lock_owner == (long) _thread_run) > return; This is redundent code. I'll remove it. I often use the debug version to discover if this recursion exists. -- John Birrell - jb@cimlogic.com.au; jb@freebsd.org http://www.cimlogic.com.au/ CIMlogic Pty Ltd, GPO Box 117A, Melbourne Vic 3001, Australia +61 418 353 137