From owner-cvs-src@FreeBSD.ORG Thu Apr 10 09:42:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D5C937B404 for ; Thu, 10 Apr 2003 09:42:25 -0700 (PDT) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EB7343F85 for ; Thu, 10 Apr 2003 09:42:23 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 9385 invoked from network); 10 Apr 2003 16:42:26 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 10 Apr 2003 16:42:26 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h3AGg2Ov052942; Thu, 10 Apr 2003 12:42:06 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200304092207.h39M72h5058124@repoman.freebsd.org> Date: Thu, 10 Apr 2003 12:42:02 -0400 (EDT) From: John Baldwin To: Warner Losh cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/pccard pccard.c pccardvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Apr 2003 16:42:26 -0000 On 09-Apr-2003 Warner Losh wrote: > imp 2003/04/09 15:07:02 PDT > > FreeBSD src repository > > Modified files: > sys/dev/pccard pccard.c pccardvar.h > Log: > 1.77 was bogus: there is no logic bug. Back it out and compare the > correct fields instead. At this point it doesn't matter since you only check one field now, but there was definitely a logic bug in both 1.76 and 1.78. If you want to terminate a loop when both a and b are zero, you can do either: for (...; a != 0 || b != 0; ...) or: for (...; !(a == 0 && b == 0); ...) However, both 1.76 and 1.78 did: for (...; a != 0 && b != 0; ...) Which will terminate the first time either a or b is zero, not when both are zero. The fact that my wavelan card didn't probe until 1.77 should help to prove that. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/